Re: [PATCH v3 3/6] mm/writeback: commit reason of WB_REASON_FORKER_THREAD mismatch name

[Wanpeng Li <liwanp@linux.vnet.ibm.com>]

On Tue, Jun 18, 2013 at 12:01:39PM -0700, Tejun Heo wrote:
>On Tue, Jun 18, 2013 at 07:33:39PM +0800, Wanpeng Li wrote:
>> After commit 839a8e86("writeback: replace custom worker pool implementation
>> with unbound workqueue"), there is no bdi forker thread any more. However,
>> WB_REASON_FORKER_THREAD is still used due to it is somewhat userland visible
>> and we won't be exposing exactly the same information with just a different
>> name.
>> 
>> Signed-off-by: Wanpeng Li <liwanp@linux.vnet.ibm.com>
>
>Reviewed-by: Tejun Heo <tj@kernel.org>
>
>> +/*
>> + * There is no bdi forker thread any more and works are done by emergency
>> + * worker, however, this is somewhat userland visible and we'll be exposing
>> + * exactly the same information, so it has a mismatch name.
>> + */
>>  	WB_REASON_FORKER_THREAD,
>
>But it'd be probably better to explicitly point to the TPs rather than
>saying "somewhat" visible.

Thanks for your review, Tejun, I will update them in next version. ;-)

Regards,
Wanpeng Li 

>
>Thanks.
>
>-- 
>tejun

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>