From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from e39.co.us.ibm.com (e39.co.us.ibm.com [32.97.110.160]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "e39.co.us.ibm.com", Issuer "GeoTrust SSL CA" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 125AA2C02F5 for ; Wed, 19 Jun 2013 15:33:19 +1000 (EST) Received: from /spool/local by e39.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 18 Jun 2013 23:33:18 -0600 Received: from d01relay02.pok.ibm.com (d01relay02.pok.ibm.com [9.56.227.234]) by d01dlp01.pok.ibm.com (Postfix) with ESMTP id BE08538C8042 for ; Wed, 19 Jun 2013 01:33:13 -0400 (EDT) Received: from d01av01.pok.ibm.com (d01av01.pok.ibm.com [9.56.224.215]) by d01relay02.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r5J5W584263236 for ; Wed, 19 Jun 2013 01:32:05 -0400 Received: from d01av01.pok.ibm.com (loopback [127.0.0.1]) by d01av01.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r5J5W3G7010446 for ; Wed, 19 Jun 2013 01:32:05 -0400 Date: Tue, 18 Jun 2013 22:31:13 -0700 From: Sukadev Bhattiprolu To: Michael Neuling Subject: Re: [PATCH 1/2] perf/Power7: Save dcache_src fields in sample record. Message-ID: <20130619053113.GA5025@us.ibm.com> References: <20130607204008.GA3281@us.ibm.com> <23819.1371616910@ale.ozlabs.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <23819.1371616910@ale.ozlabs.ibm.com> Cc: Anton Blanchard , linux-kernel@vger.kernel.org, Stephane Eranian , linuxppc-dev@ozlabs.org, Paul Mackerras , mingo@kernel.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Michael Neuling [mikey@neuling.org] wrote: | Suka, | | One of these two patches breaks pmac32_defconfig and I suspect all other | 32 bit configs (against mainline) | | arch/powerpc/perf/core-book3s.c: In function 'record_and_restart': | arch/powerpc/perf/core-book3s.c:1632:4: error: passing argument 1 of 'ppmu->get_mem_data_src' from incompatible pointer type [-Werror] | arch/powerpc/perf/core-book3s.c:1632:4: note: expected 'struct perf_sample_data *' but argument is of type 'struct perf_sample_data *' | | benh is busy enough without this junk. Please check the simple things | like white space and compile errors! Sorry about that. BTW, this was an early patch more to get some feedback on mapping of memory hierarchy levels to Power and not intended to be merged. I have been reworking the patch based on other comments. Sukadev From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756132Ab3FSFcL (ORCPT ); Wed, 19 Jun 2013 01:32:11 -0400 Received: from e9.ny.us.ibm.com ([32.97.182.139]:59765 "EHLO e9.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752227Ab3FSFcK (ORCPT ); Wed, 19 Jun 2013 01:32:10 -0400 Date: Tue, 18 Jun 2013 22:31:13 -0700 From: Sukadev Bhattiprolu To: Michael Neuling Cc: mingo@kernel.org, Paul Mackerras , linuxppc-dev@ozlabs.org, Anton Blanchard , linux-kernel@vger.kernel.org, Stephane Eranian Subject: Re: [PATCH 1/2] perf/Power7: Save dcache_src fields in sample record. Message-ID: <20130619053113.GA5025@us.ibm.com> References: <20130607204008.GA3281@us.ibm.com> <23819.1371616910@ale.ozlabs.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <23819.1371616910@ale.ozlabs.ibm.com> X-Operating-System: Linux 2.0.32 on an i486 User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: No X-Content-Scanned: Fidelis XPS MAILER x-cbid: 13061905-7182-0000-0000-000007662AED Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Michael Neuling [mikey@neuling.org] wrote: | Suka, | | One of these two patches breaks pmac32_defconfig and I suspect all other | 32 bit configs (against mainline) | | arch/powerpc/perf/core-book3s.c: In function 'record_and_restart': | arch/powerpc/perf/core-book3s.c:1632:4: error: passing argument 1 of 'ppmu->get_mem_data_src' from incompatible pointer type [-Werror] | arch/powerpc/perf/core-book3s.c:1632:4: note: expected 'struct perf_sample_data *' but argument is of type 'struct perf_sample_data *' | | benh is busy enough without this junk. Please check the simple things | like white space and compile errors! Sorry about that. BTW, this was an early patch more to get some feedback on mapping of memory hierarchy levels to Power and not intended to be merged. I have been reworking the patch based on other comments. Sukadev