From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH v2 1/2] mfd: tps65910: Fix crash in i2c_driver .probe Date: Wed, 19 Jun 2013 09:18:59 +0100 Message-ID: <20130619081859.GA22998@laptop> References: <1371550481-28126-1-git-send-email-ttynkkynen@nvidia.com> <1371550481-28126-2-git-send-email-ttynkkynen@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <1371550481-28126-2-git-send-email-ttynkkynen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Tuomas Tynkkynen Cc: Samuel Ortiz , Mark Brown , Wolfram Sang , linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Linus Walleij List-Id: linux-i2c@vger.kernel.org On Tue, 18 Jun 2013, Tuomas Tynkkynen wrote: > Commit "i2c: core: make it possible to match a pure device tree drive= r" > changed semantics of the i2c probing for device tree devices. > Device tree probed devices now get a NULL i2c_device_id pointer. > This caused kernel panics due to NULL dereference. >=20 > Moves the of_match_device call from tps65910_parse_dt to .probe to > allow the chip type to be detected from device tree but with the > device parameters coming from platform data. >=20 > Signed-off-by: Tuomas Tynkkynen Applied with Stephen's Reviewed-by, thanks. --=20 Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756728Ab3FSITM (ORCPT ); Wed, 19 Jun 2013 04:19:12 -0400 Received: from mail-bk0-f46.google.com ([209.85.214.46]:53707 "EHLO mail-bk0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756700Ab3FSITG (ORCPT ); Wed, 19 Jun 2013 04:19:06 -0400 Date: Wed, 19 Jun 2013 09:18:59 +0100 From: Lee Jones To: Tuomas Tynkkynen Cc: Samuel Ortiz , Mark Brown , Wolfram Sang , linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, Linus Walleij Subject: Re: [PATCH v2 1/2] mfd: tps65910: Fix crash in i2c_driver .probe Message-ID: <20130619081859.GA22998@laptop> References: <1371550481-28126-1-git-send-email-ttynkkynen@nvidia.com> <1371550481-28126-2-git-send-email-ttynkkynen@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1371550481-28126-2-git-send-email-ttynkkynen@nvidia.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 18 Jun 2013, Tuomas Tynkkynen wrote: > Commit "i2c: core: make it possible to match a pure device tree driver" > changed semantics of the i2c probing for device tree devices. > Device tree probed devices now get a NULL i2c_device_id pointer. > This caused kernel panics due to NULL dereference. > > Moves the of_match_device call from tps65910_parse_dt to .probe to > allow the chip type to be detected from device tree but with the > device parameters coming from platform data. > > Signed-off-by: Tuomas Tynkkynen Applied with Stephen's Reviewed-by, thanks. -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog