From mboxrd@z Thu Jan 1 00:00:00 1970 From: ezequiel.garcia@free-electrons.com (Ezequiel Garcia) Date: Wed, 19 Jun 2013 07:02:00 -0300 Subject: [PATCH v3 05/12] ARM: mvebu: Remove the harcoded BootROM window allocation In-Reply-To: <20130618173906.GC2204@obsidianresearch.com> References: <1371554737-25319-1-git-send-email-ezequiel.garcia@free-electrons.com> <1371554737-25319-6-git-send-email-ezequiel.garcia@free-electrons.com> <20130618173906.GC2204@obsidianresearch.com> Message-ID: <20130619100159.GB16138@localhost> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Jun 18, 2013 at 11:39:06AM -0600, Jason Gunthorpe wrote: > On Tue, Jun 18, 2013 at 08:25:30AM -0300, Ezequiel Garcia wrote: > > The address decoding window to access the BootROM should not be > > allocated programatically, but instead declared in the device tree. > > > > Signed-off-by: Ezequiel Garcia > > arch/arm/mach-mvebu/platsmp.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/arch/arm/mach-mvebu/platsmp.c b/arch/arm/mach-mvebu/platsmp.c > > index 93f2f3a..d419fac 100644 > > +++ b/arch/arm/mach-mvebu/platsmp.c > > @@ -118,7 +118,6 @@ void __init armada_xp_smp_prepare_cpus(unsigned int max_cpus) > > set_secondary_cpus_clock(); > > flush_cache_all(); > > set_cpu_coherent(cpu_logical_map(smp_processor_id()), 0); > > - mvebu_mbus_add_window("bootrom", 0xfff00000, SZ_1M); > > } > > I think some kind of test is needed here. As I understand it the SMP > startup uses a trampoline in the boot rom and the boot rom *must* be > mapped to 0xfff00000 ? > Indeed, setting up 0xfff00000 is a *must*. > Verifying the DT is setup this way and aborting if it is not seems > like a good idea.. > I agree it's a nice idea, but I'm not too sure how to accomplish this in a simple and generic way. There's nothing in the DT that allows you to know which of the ranges entries correspond to the BootROM, unless you go through each of the entries comparing against the known target ID and attribute. You could also do a 'of_find_node_by_name(NULL, "bootrom");' but the binding no longer requires to even have any children for the window. Any ideas? -- Ezequiel Garc?a, Free Electrons Embedded Linux, Kernel and Android Engineering http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ezequiel Garcia Subject: Re: [PATCH v3 05/12] ARM: mvebu: Remove the harcoded BootROM window allocation Date: Wed, 19 Jun 2013 07:02:00 -0300 Message-ID: <20130619100159.GB16138@localhost> References: <1371554737-25319-1-git-send-email-ezequiel.garcia@free-electrons.com> <1371554737-25319-6-git-send-email-ezequiel.garcia@free-electrons.com> <20130618173906.GC2204@obsidianresearch.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20130618173906.GC2204-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Jason Gunthorpe Cc: Andrew Lunn , Jason Cooper , devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, Maen Suleiman , Lior Amsalem , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Sebastian Hesselbarth List-Id: devicetree@vger.kernel.org T24gVHVlLCBKdW4gMTgsIDIwMTMgYXQgMTE6Mzk6MDZBTSAtMDYwMCwgSmFzb24gR3VudGhvcnBl IHdyb3RlOgo+IE9uIFR1ZSwgSnVuIDE4LCAyMDEzIGF0IDA4OjI1OjMwQU0gLTAzMDAsIEV6ZXF1 aWVsIEdhcmNpYSB3cm90ZToKPiA+IFRoZSBhZGRyZXNzIGRlY29kaW5nIHdpbmRvdyB0byBhY2Nl c3MgdGhlIEJvb3RST00gc2hvdWxkIG5vdCBiZQo+ID4gYWxsb2NhdGVkIHByb2dyYW1hdGljYWxs eSwgYnV0IGluc3RlYWQgZGVjbGFyZWQgaW4gdGhlIGRldmljZSB0cmVlLgo+ID4gCj4gPiBTaWdu ZWQtb2ZmLWJ5OiBFemVxdWllbCBHYXJjaWEgPGV6ZXF1aWVsLmdhcmNpYUBmcmVlLWVsZWN0cm9u cy5jb20+Cj4gPiAgYXJjaC9hcm0vbWFjaC1tdmVidS9wbGF0c21wLmMgfCAxIC0KPiA+ICAxIGZp bGUgY2hhbmdlZCwgMSBkZWxldGlvbigtKQo+ID4gCj4gPiBkaWZmIC0tZ2l0IGEvYXJjaC9hcm0v bWFjaC1tdmVidS9wbGF0c21wLmMgYi9hcmNoL2FybS9tYWNoLW12ZWJ1L3BsYXRzbXAuYwo+ID4g aW5kZXggOTNmMmYzYS4uZDQxOWZhYyAxMDA2NDQKPiA+ICsrKyBiL2FyY2gvYXJtL21hY2gtbXZl YnUvcGxhdHNtcC5jCj4gPiBAQCAtMTE4LDcgKzExOCw2IEBAIHZvaWQgX19pbml0IGFybWFkYV94 cF9zbXBfcHJlcGFyZV9jcHVzKHVuc2lnbmVkIGludCBtYXhfY3B1cykKPiA+ICAJc2V0X3NlY29u ZGFyeV9jcHVzX2Nsb2NrKCk7Cj4gPiAgCWZsdXNoX2NhY2hlX2FsbCgpOwo+ID4gIAlzZXRfY3B1 X2NvaGVyZW50KGNwdV9sb2dpY2FsX21hcChzbXBfcHJvY2Vzc29yX2lkKCkpLCAwKTsKPiA+IC0J bXZlYnVfbWJ1c19hZGRfd2luZG93KCJib290cm9tIiwgMHhmZmYwMDAwMCwgU1pfMU0pOwo+ID4g IH0KPiAKPiBJIHRoaW5rIHNvbWUga2luZCBvZiB0ZXN0IGlzIG5lZWRlZCBoZXJlLiBBcyBJIHVu ZGVyc3RhbmQgaXQgdGhlIFNNUAo+IHN0YXJ0dXAgdXNlcyBhIHRyYW1wb2xpbmUgaW4gdGhlIGJv b3Qgcm9tIGFuZCB0aGUgYm9vdCByb20gKm11c3QqIGJlCj4gbWFwcGVkIHRvIDB4ZmZmMDAwMDAg Pwo+IAoKSW5kZWVkLCBzZXR0aW5nIHVwIDB4ZmZmMDAwMDAgaXMgYSAqbXVzdCouCgo+IFZlcmlm eWluZyB0aGUgRFQgaXMgc2V0dXAgdGhpcyB3YXkgYW5kIGFib3J0aW5nIGlmIGl0IGlzIG5vdCBz ZWVtcwo+IGxpa2UgYSBnb29kIGlkZWEuLgo+IAoKSSBhZ3JlZSBpdCdzIGEgbmljZSBpZGVhLCBi dXQgSSdtIG5vdCB0b28gc3VyZSBob3cgdG8gYWNjb21wbGlzaCB0aGlzCmluIGEgc2ltcGxlIGFu ZCBnZW5lcmljIHdheS4gVGhlcmUncyBub3RoaW5nIGluIHRoZSBEVCB0aGF0IGFsbG93cyB5b3UK dG8ga25vdyB3aGljaCBvZiB0aGUgcmFuZ2VzIGVudHJpZXMgY29ycmVzcG9uZCB0byB0aGUgQm9v dFJPTSwgdW5sZXNzIHlvdSBnbwp0aHJvdWdoIGVhY2ggb2YgdGhlIGVudHJpZXMgY29tcGFyaW5n IGFnYWluc3QgdGhlIGtub3duIHRhcmdldCBJRCBhbmQKYXR0cmlidXRlLgoKWW91IGNvdWxkIGFs c28gZG8gYSAnb2ZfZmluZF9ub2RlX2J5X25hbWUoTlVMTCwgImJvb3Ryb20iKTsnIGJ1dCB0aGUg YmluZGluZwpubyBsb25nZXIgcmVxdWlyZXMgdG8gZXZlbiBoYXZlIGFueSBjaGlsZHJlbiBmb3Ig dGhlIHdpbmRvdy4KCkFueSBpZGVhcz8KCi0tIApFemVxdWllbCBHYXJjw61hLCBGcmVlIEVsZWN0 cm9ucwpFbWJlZGRlZCBMaW51eCwgS2VybmVsIGFuZCBBbmRyb2lkIEVuZ2luZWVyaW5nCmh0dHA6 Ly9mcmVlLWVsZWN0cm9ucy5jb20KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KZGV2aWNldHJlZS1kaXNjdXNzIG1haWxpbmcgbGlzdApkZXZpY2V0cmVlLWRp c2N1c3NAbGlzdHMub3psYWJzLm9yZwpodHRwczovL2xpc3RzLm96bGFicy5vcmcvbGlzdGluZm8v ZGV2aWNldHJlZS1kaXNjdXNzCg==