From mboxrd@z Thu Jan 1 00:00:00 1970 From: ezequiel.garcia@free-electrons.com (Ezequiel Garcia) Date: Wed, 19 Jun 2013 08:12:58 -0300 Subject: [PATCH v3 11/12] ARM: mvebu: Relocate Armada 370 PCIe device tree nodes In-Reply-To: <201306182335.50722.arnd@arndb.de> References: <1371554737-25319-1-git-send-email-ezequiel.garcia@free-electrons.com> <1371554737-25319-12-git-send-email-ezequiel.garcia@free-electrons.com> <201306182335.50722.arnd@arndb.de> Message-ID: <20130619111257.GD16138@localhost> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Arnd, Going through this a couple questions came out... On Tue, Jun 18, 2013 at 11:35:50PM +0200, Arnd Bergmann wrote: > On Tuesday 18 June 2013, Ezequiel Garcia wrote: > > + > > + ranges = > > + <0x82000000 0 0x40000 0xffff0001 0x40000 0 0x00002000 > > + 0x82000000 0 0x80000 0xffff0001 0x80000 0 0x00002000 > > + 0x82000000 0 0xe0000000 0xffff0002 0 0 0x08000000 > > + 0x81000000 0 0 0xffff0002 0x8000000 0 0x00100000>; > > As pointed out on IRC, this is not a good representation of the memory space, > since it requires a non-zero sys->mem_offset, and it conflicts with the straight > mapping I suggested. > > I think it should be > > 0x82000000 0 0xe0000000 0xffff0002 0 0xe0000000 0x08000000 So far, so good. > > if we want to encode the aperture in the ranges property here, i.e. have > a 1:1 mapping between PCI memory space and MBUS space, and in mbus, > you need the corresponding > > - 0xffff0002 0 0xe0000000 0x8100000 > + 0xffff0002 0xe0000000 0xe0000000 0x8100000 ... I obviously got something wrong, but I thought you said that this change allowed to *not* have any mbus-node ranges translation. > > so that mbus actually translates the right addresses. You could also > have the PCI memory space start at 0, which would mean > > 0x82000000 0 0 0xffff0002 0 0 0x08000000 > > and > > 0xffff0002 0 0xe0000000 0x8100000 Mmm.. and why is this option acceptable? > > Note that the driver doesn't actually handle the generic case correctly, you would > need to apply this patch > This patch does not apply. I tried to understand what you did, but I'm confused by the fact I don't need to apply any patch to make it work on my boxes, using your proposed ranges translations. > diff --git a/drivers/pci/host/pci-mvebu.c b/drivers/pci/host/pci-mvebu.c > index 13a633b..aa674f4 100644 > --- a/drivers/pci/host/pci-mvebu.c > +++ b/drivers/pci/host/pci-mvebu.c > @@ -790,6 +790,7 @@ static int __init mvebu_pcie_probe(struct platform_device *pdev) > } > if (restype == IORESOURCE_MEM) { > of_pci_range_to_resource(&range, np, &pcie->mem); > + sys->mem_offset = range.cpu_addr - range.pci_addr; > pcie->mem.name = "MEM"; > } > } > > to deal with the generic case where the bus address is different from the > CPU address. > Thanks! -- Ezequiel Garc?a, Free Electrons Embedded Linux, Kernel and Android Engineering http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ezequiel Garcia Subject: Re: [PATCH v3 11/12] ARM: mvebu: Relocate Armada 370 PCIe device tree nodes Date: Wed, 19 Jun 2013 08:12:58 -0300 Message-ID: <20130619111257.GD16138@localhost> References: <1371554737-25319-1-git-send-email-ezequiel.garcia@free-electrons.com> <1371554737-25319-12-git-send-email-ezequiel.garcia@free-electrons.com> <201306182335.50722.arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <201306182335.50722.arnd-r2nGTMty4D4@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Arnd Bergmann Cc: Andrew Lunn , Jason Cooper , devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, Jason Gunthorpe , Maen Suleiman , Lior Amsalem , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Sebastian Hesselbarth List-Id: devicetree@vger.kernel.org QXJuZCwKCkdvaW5nIHRocm91Z2ggdGhpcyBhIGNvdXBsZSBxdWVzdGlvbnMgY2FtZSBvdXQuLi4K Ck9uIFR1ZSwgSnVuIDE4LCAyMDEzIGF0IDExOjM1OjUwUE0gKzAyMDAsIEFybmQgQmVyZ21hbm4g d3JvdGU6Cj4gT24gVHVlc2RheSAxOCBKdW5lIDIwMTMsIEV6ZXF1aWVsIEdhcmNpYSB3cm90ZToK PiA+ICsKPiA+ICsgICAgICAgICAgICAgICAgICAgICAgIHJhbmdlcyA9Cj4gPiArICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgPDB4ODIwMDAwMDAgMCAweDQwMDAwICAgIDB4ZmZmZjAwMDEg MHg0MDAwMCAwIDB4MDAwMDIwMDAKPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg MHg4MjAwMDAwMCAwIDB4ODAwMDAgICAgMHhmZmZmMDAwMSAweDgwMDAwIDAgMHgwMDAwMjAwMAo+ ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAweDgyMDAwMDAwIDAgMHhlMDAwMDAw MCAweGZmZmYwMDAyIDAgICAgICAgICAgMCAweDA4MDAwMDAwCj4gPiArICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIDB4ODEwMDAwMDAgMCAwICAgICAgICAgIDB4ZmZmZjAwMDIgMHg4MDAw MDAwICAwIDB4MDAxMDAwMDA+Owo+IAo+IEFzIHBvaW50ZWQgb3V0IG9uIElSQywgdGhpcyBpcyBu b3QgYSBnb29kIHJlcHJlc2VudGF0aW9uIG9mIHRoZSBtZW1vcnkgc3BhY2UsCj4gc2luY2UgaXQg cmVxdWlyZXMgYSBub24temVybyBzeXMtPm1lbV9vZmZzZXQsIGFuZCBpdCBjb25mbGljdHMgd2l0 aCB0aGUgc3RyYWlnaHQKPiBtYXBwaW5nIEkgc3VnZ2VzdGVkLgo+IAo+IEkgdGhpbmsgaXQgc2hv dWxkIGJlCj4gCj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDB4ODIwMDAwMDAgMCAw eGUwMDAwMDAwIDB4ZmZmZjAwMDIgMCAgMHhlMDAwMDAwMCAweDA4MDAwMDAwCgpTbyBmYXIsIHNv IGdvb2QuCgo+IAo+IGlmIHdlIHdhbnQgdG8gZW5jb2RlIHRoZSBhcGVydHVyZSBpbiB0aGUgcmFu Z2VzIHByb3BlcnR5IGhlcmUsIGkuZS4gaGF2ZQo+IGEgMToxIG1hcHBpbmcgYmV0d2VlbiBQQ0kg bWVtb3J5IHNwYWNlIGFuZCBNQlVTIHNwYWNlLCBhbmQgaW4gbWJ1cywKPiB5b3UgbmVlZCB0aGUg Y29ycmVzcG9uZGluZwo+IAo+IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAweGZmZmYwMDAy IDAgMHhlMDAwMDAwMCAweDgxMDAwMDAKPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgMHhm ZmZmMDAwMiAweGUwMDAwMDAwIDB4ZTAwMDAwMDAgMHg4MTAwMDAwCgouLi4gSSBvYnZpb3VzbHkg Z290IHNvbWV0aGluZyB3cm9uZywgYnV0IEkgdGhvdWdodCB5b3Ugc2FpZCB0aGF0CnRoaXMgY2hh bmdlIGFsbG93ZWQgdG8gKm5vdCogaGF2ZSBhbnkgbWJ1cy1ub2RlIHJhbmdlcyB0cmFuc2xhdGlv bi4KCj4gCj4gc28gdGhhdCBtYnVzIGFjdHVhbGx5IHRyYW5zbGF0ZXMgdGhlIHJpZ2h0IGFkZHJl c3Nlcy4gWW91IGNvdWxkIGFsc28KPiBoYXZlIHRoZSBQQ0kgbWVtb3J5IHNwYWNlIHN0YXJ0IGF0 IDAsIHdoaWNoIHdvdWxkIG1lYW4KPiAKPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg MHg4MjAwMDAwMCAwIDAgMHhmZmZmMDAwMiAwICAwIDB4MDgwMDAwMDAKPiAKPiBhbmQKPiAKPiAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAweGZmZmYwMDAyIDAgMHhlMDAwMDAwMCAweDgx MDAwMDAKCk1tbS4uIGFuZCB3aHkgaXMgdGhpcyBvcHRpb24gYWNjZXB0YWJsZT8KCj4gCj4gTm90 ZSB0aGF0IHRoZSBkcml2ZXIgZG9lc24ndCBhY3R1YWxseSBoYW5kbGUgdGhlIGdlbmVyaWMgY2Fz ZSBjb3JyZWN0bHksIHlvdSB3b3VsZAo+IG5lZWQgdG8gYXBwbHkgdGhpcyBwYXRjaAo+CgpUaGlz IHBhdGNoIGRvZXMgbm90IGFwcGx5LiBJIHRyaWVkIHRvIHVuZGVyc3RhbmQgd2hhdCB5b3UgZGlk LCBidXQgSSdtCmNvbmZ1c2VkIGJ5IHRoZSBmYWN0IEkgZG9uJ3QgbmVlZCB0byBhcHBseSBhbnkg cGF0Y2ggdG8gbWFrZSBpdCB3b3JrCm9uIG15IGJveGVzLCB1c2luZyB5b3VyIHByb3Bvc2VkIHJh bmdlcyB0cmFuc2xhdGlvbnMuCgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3BjaS9ob3N0L3BjaS1t dmVidS5jIGIvZHJpdmVycy9wY2kvaG9zdC9wY2ktbXZlYnUuYwo+IGluZGV4IDEzYTYzM2IuLmFh Njc0ZjQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9wY2kvaG9zdC9wY2ktbXZlYnUuYwo+ICsrKyBi L2RyaXZlcnMvcGNpL2hvc3QvcGNpLW12ZWJ1LmMKPiBAQCAtNzkwLDYgKzc5MCw3IEBAIHN0YXRp YyBpbnQgX19pbml0IG12ZWJ1X3BjaWVfcHJvYmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRl dikKPiAgCQl9Cj4gIAkJaWYgKHJlc3R5cGUgPT0gSU9SRVNPVVJDRV9NRU0pIHsKPiAgCQkJb2Zf cGNpX3JhbmdlX3RvX3Jlc291cmNlKCZyYW5nZSwgbnAsICZwY2llLT5tZW0pOwo+ICsJCQlzeXMt Pm1lbV9vZmZzZXQgPSByYW5nZS5jcHVfYWRkciAtIHJhbmdlLnBjaV9hZGRyOwo+ICAJCQlwY2ll LT5tZW0ubmFtZSA9ICJNRU0iOwo+ICAJCX0KPiAgCX0KPiAKPiB0byBkZWFsIHdpdGggdGhlIGdl bmVyaWMgY2FzZSB3aGVyZSB0aGUgYnVzIGFkZHJlc3MgaXMgZGlmZmVyZW50IGZyb20gdGhlCj4g Q1BVIGFkZHJlc3MuCj4gCgpUaGFua3MhCi0tIApFemVxdWllbCBHYXJjw61hLCBGcmVlIEVsZWN0 cm9ucwpFbWJlZGRlZCBMaW51eCwgS2VybmVsIGFuZCBBbmRyb2lkIEVuZ2luZWVyaW5nCmh0dHA6 Ly9mcmVlLWVsZWN0cm9ucy5jb20KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KZGV2aWNldHJlZS1kaXNjdXNzIG1haWxpbmcgbGlzdApkZXZpY2V0cmVlLWRp c2N1c3NAbGlzdHMub3psYWJzLm9yZwpodHRwczovL2xpc3RzLm96bGFicy5vcmcvbGlzdGluZm8v ZGV2aWNldHJlZS1kaXNjdXNzCg==