All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Cc: e1000-devel@lists.sourceforge.net, netdev@vger.kernel.org,
	Jesse Brandeburg <jesse.brandeburg@intel.com>,
	sassmann@redhat.com, gospo@redhat.com, davem@davemloft.net,
	Shannon
Subject: Re: [net-next 3/8] i40e: driver ethtool core
Date: Wed, 19 Jun 2013 11:40:09 -0700	[thread overview]
Message-ID: <20130619114009.1d4ece23@samsung-9> (raw)
In-Reply-To: <1371182122-26629-4-git-send-email-jeffrey.t.kirsher@intel.com>

On Thu, 13 Jun 2013 20:55:17 -0700
Jeff Kirsher <jeffrey.t.kirsher@intel.com> wrote:

> +
> +/**
> + * i40e_set_settings - Set Speed and Duplex
> + * @netdev: network interface device structure
> + * @ecmd: ethtool command
> + *
> + * Set speed/duplex per media_types advertised/forced
> + **/
> +static int i40e_set_settings(struct net_device *netdev,
> +			     struct ethtool_cmd *ecmd)
> +{
> +	return -EOPNOTSUPP;
> +}
> +

Stub not needed, if ethtool_ops.set_settings is NULL, then ethtool_set_settings
will do this for you.

------------------------------------------------------------------------------
This SF.net email is sponsored by Windows:

Build for Windows Store.

http://p.sf.net/sfu/windows-dev2dev
_______________________________________________
E1000-devel mailing list
E1000-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel&#174; Ethernet, visit http://communities.intel.com/community/wired

  parent reply	other threads:[~2013-06-19 18:40 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-14  3:55 [net-next 0/8][pull request] Intel Wired LAN Driver Updates Jeff Kirsher
2013-06-14  3:55 ` [net-next 1/8] i40e: main driver core Jeff Kirsher
2013-06-14  5:29   ` Joe Perches
2013-06-16 21:34     ` Nelson, Shannon
2013-06-19 18:12   ` Ben Hutchings
2013-06-20  6:41     ` Nelson, Shannon
2013-06-20 19:46     ` Nelson, Shannon
2013-06-20 19:54       ` Ben Hutchings
2013-06-20 20:01         ` Nelson, Shannon
2013-06-20 20:52           ` Peter P Waskiewicz Jr
2013-06-19 18:55   ` Stephen Hemminger
2013-06-20  6:41     ` Nelson, Shannon
2013-06-20 20:50     ` Nelson, Shannon
2013-06-14  3:55 ` [net-next 2/8] i40e: transmit, receive, and napi Jeff Kirsher
2013-06-14  3:55 ` [net-next 3/8] i40e: driver ethtool core Jeff Kirsher
2013-06-19 18:27   ` Ben Hutchings
2013-06-20 19:47     ` Nelson, Shannon
2013-06-20 19:59       ` Ben Hutchings
2013-06-20 20:04         ` Nelson, Shannon
2013-06-21 15:39           ` Structured ethtool statistic names Ben Hutchings
2013-06-25 20:46             ` Nelson, Shannon
2013-06-19 18:38   ` [net-next 3/8] i40e: driver ethtool core Stephen Hemminger
2013-06-20 20:52     ` Nelson, Shannon
2013-06-19 18:40   ` Stephen Hemminger [this message]
2013-06-20 20:53     ` Nelson, Shannon
2013-06-19 18:41   ` Stephen Hemminger
2013-06-20 20:53     ` Nelson, Shannon
2013-06-14  3:55 ` [net-next 4/8] i40e: driver core headers Jeff Kirsher
2013-06-14  3:55 ` [net-next 5/8] i40e: implement virtual device interface Jeff Kirsher
2013-06-14  3:55 ` [net-next 6/8] i40e: init code and hardware support Jeff Kirsher
2013-06-14  3:55 ` [net-next 7/8] i40e: sysfs and debugfs interfaces Jeff Kirsher
2013-06-14  3:55 ` [net-next 8/8] i40e: include i40e in kernel proper Jeff Kirsher
  -- strict thread matches above, loose matches on Subject: below --
2013-09-06  5:43 [net-next 0/8][pull request] Intel Wired LAN Driver Updates Jeff Kirsher
2013-09-06  5:43 ` [net-next 3/8] i40e: driver ethtool core Jeff Kirsher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130619114009.1d4ece23@samsung-9 \
    --to=stephen@networkplumber.org \
    --cc=davem@davemloft.net \
    --cc=e1000-devel@lists.sourceforge.net \
    --cc=gospo@redhat.com \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=jesse.brandeburg@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=sassmann@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.