* [PATCH] Fix segfault in read_distance_table when no NUMA
@ 2013-06-19 11:56 Ian Wienand
0 siblings, 0 replies; only message in thread
From: Ian Wienand @ 2013-06-19 11:56 UTC (permalink / raw)
To: linux-numa; +Cc: 712692
Hi
Debian bug #712692 reported a segfault on systems with no numa info.
In this case, read_distance_table would exit with "0" which was not
picked up as an error by numa_distance(), leading to a dereference of
distance_table.
Signed-off-by: Ian Wienand <ian@wienand.org>
---
distance.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/distance.c b/distance.c
index 4a26972..ec423c4 100755
--- a/distance.c
+++ b/distance.c
@@ -58,15 +58,13 @@ static int read_distance_table(void)
int *table = NULL;
int err = -1;
- for (nd = 0;; nd++) {
+ for (nd = 0; nd<maxnode; nd++) {
char fn[100];
FILE *dfh;
sprintf(fn, "/sys/devices/system/node/node%d/distance", nd);
dfh = fopen(fn, "r");
if (!dfh) {
if (errno == ENOENT)
- err = 0;
- if (!err && nd<maxnode)
continue;
else
break;
--
1.7.10.4
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2013-06-19 11:56 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-19 11:56 [PATCH] Fix segfault in read_distance_table when no NUMA Ian Wienand
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.