From mboxrd@z Thu Jan 1 00:00:00 1970 From: ezequiel.garcia@free-electrons.com (Ezequiel Garcia) Date: Wed, 19 Jun 2013 15:17:36 -0300 Subject: [PATCH v3 05/12] ARM: mvebu: Remove the harcoded BootROM window allocation In-Reply-To: <20130619180320.GA25000@obsidianresearch.com> References: <1371554737-25319-1-git-send-email-ezequiel.garcia@free-electrons.com> <1371554737-25319-6-git-send-email-ezequiel.garcia@free-electrons.com> <20130618173906.GC2204@obsidianresearch.com> <20130619100159.GB16138@localhost> <20130619165834.GB32155@obsidianresearch.com> <20130619175823.GB2324@localhost> <20130619180320.GA25000@obsidianresearch.com> Message-ID: <20130619181735.GA5701@localhost> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Jun 19, 2013 at 12:03:20PM -0600, Jason Gunthorpe wrote: > On Wed, Jun 19, 2013 at 02:58:24PM -0300, Ezequiel Garcia wrote: > > > I wasn't sure you wanted to panic(), to clip on available CPUs, > > or to just do a pr_warn / WARN(), so here's a piece of code: > > (disclaimer: non-tested, non-compiled, etc.) > > Up to you, but you know it won't work if it isn't right so continuing > on to try and startup the CPUs is not ideal. panic is probably > reasonable? > Well, the other CPUs don't start but the system itself does not die, (or at least that's the case on my systems). It's up to you, I'm fine with either, although I'm inclined to just panic. > > node = of_find_compatible_node(NULL, NULL, "bootrom"); > > "marvell,bootrom" ? > Yes, indeed. -- Ezequiel Garc?a, Free Electrons Embedded Linux, Kernel and Android Engineering http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ezequiel Garcia Subject: Re: [PATCH v3 05/12] ARM: mvebu: Remove the harcoded BootROM window allocation Date: Wed, 19 Jun 2013 15:17:36 -0300 Message-ID: <20130619181735.GA5701@localhost> References: <1371554737-25319-1-git-send-email-ezequiel.garcia@free-electrons.com> <1371554737-25319-6-git-send-email-ezequiel.garcia@free-electrons.com> <20130618173906.GC2204@obsidianresearch.com> <20130619100159.GB16138@localhost> <20130619165834.GB32155@obsidianresearch.com> <20130619175823.GB2324@localhost> <20130619180320.GA25000@obsidianresearch.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20130619180320.GA25000-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Jason Gunthorpe Cc: Andrew Lunn , Jason Cooper , devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, Maen Suleiman , Lior Amsalem , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Sebastian Hesselbarth List-Id: devicetree@vger.kernel.org T24gV2VkLCBKdW4gMTksIDIwMTMgYXQgMTI6MDM6MjBQTSAtMDYwMCwgSmFzb24gR3VudGhvcnBl IHdyb3RlOgo+IE9uIFdlZCwgSnVuIDE5LCAyMDEzIGF0IDAyOjU4OjI0UE0gLTAzMDAsIEV6ZXF1 aWVsIEdhcmNpYSB3cm90ZToKPiAKPiA+IEkgd2Fzbid0IHN1cmUgeW91IHdhbnRlZCB0byBwYW5p YygpLCB0byBjbGlwIG9uIGF2YWlsYWJsZSBDUFVzLAo+ID4gb3IgdG8ganVzdCBkbyBhIHByX3dh cm4gLyBXQVJOKCksIHNvIGhlcmUncyBhIHBpZWNlIG9mIGNvZGU6Cj4gPiAoZGlzY2xhaW1lcjog bm9uLXRlc3RlZCwgbm9uLWNvbXBpbGVkLCBldGMuKQo+IAo+IFVwIHRvIHlvdSwgYnV0IHlvdSBr bm93IGl0IHdvbid0IHdvcmsgaWYgaXQgaXNuJ3QgcmlnaHQgc28gY29udGludWluZwo+IG9uIHRv IHRyeSBhbmQgc3RhcnR1cCB0aGUgQ1BVcyBpcyBub3QgaWRlYWwuIHBhbmljIGlzIHByb2JhYmx5 Cj4gcmVhc29uYWJsZT8KPiAgCgpXZWxsLCB0aGUgb3RoZXIgQ1BVcyBkb24ndCBzdGFydCBidXQg dGhlIHN5c3RlbSBpdHNlbGYgZG9lcyBub3QgZGllLAoob3IgYXQgbGVhc3QgdGhhdCdzIHRoZSBj YXNlIG9uIG15IHN5c3RlbXMpLgoKSXQncyB1cCB0byB5b3UsIEknbSBmaW5lIHdpdGggZWl0aGVy LCBhbHRob3VnaCBJJ20gaW5jbGluZWQgdG8ganVzdApwYW5pYy4KCj4gPiAJbm9kZSA9IG9mX2Zp bmRfY29tcGF0aWJsZV9ub2RlKE5VTEwsIE5VTEwsICJib290cm9tIik7Cj4gCj4gIm1hcnZlbGws Ym9vdHJvbSIgPwo+IAoKWWVzLCBpbmRlZWQuCgotLSAKRXplcXVpZWwgR2FyY8OtYSwgRnJlZSBF bGVjdHJvbnMKRW1iZWRkZWQgTGludXgsIEtlcm5lbCBhbmQgQW5kcm9pZCBFbmdpbmVlcmluZwpo dHRwOi8vZnJlZS1lbGVjdHJvbnMuY29tCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmRldmljZXRyZWUtZGlzY3VzcyBtYWlsaW5nIGxpc3QKZGV2aWNldHJl ZS1kaXNjdXNzQGxpc3RzLm96bGFicy5vcmcKaHR0cHM6Ly9saXN0cy5vemxhYnMub3JnL2xpc3Rp bmZvL2RldmljZXRyZWUtZGlzY3Vzcwo=