From mboxrd@z Thu Jan 1 00:00:00 1970 From: ezequiel.garcia@free-electrons.com (Ezequiel Garcia) Date: Wed, 19 Jun 2013 15:52:25 -0300 Subject: [PATCH v3 03/12] bus: mvebu-mbus: Add static window allocation to the DT binding In-Reply-To: <201306182345.26281.arnd@arndb.de> References: <1371554737-25319-1-git-send-email-ezequiel.garcia@free-electrons.com> <201306181814.33941.arnd@arndb.de> <20130618213454.GD2516@localhost> <201306182345.26281.arnd@arndb.de> Message-ID: <20130619185224.GB5701@localhost> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Arnd, On Tue, Jun 18, 2013 at 11:45:26PM +0200, Arnd Bergmann wrote: > On Tuesday 18 June 2013, Ezequiel Garcia wrote: > > On Tue, Jun 18, 2013 at 06:14:33PM +0200, Arnd Bergmann wrote: > > > On Tuesday 18 June 2013, Ezequiel Garcia wrote: > > > > +Required properties: > > > > + > > > > +- compatible: Should be set to one of the following: > > > > + marvell,armada370-mbus > > > > + marvell,armadaxp-mbus > > > > + > > > > +- reg: Device's register space. > > > > + Two entries are expected, see the examples below. > > > > + The first one controls the devices decoding window and > > > > + the second one controls the SDRAM decoding window. > > > > + > > > > +- address-cells: Must be '2'. The first cell for the MBus ID encoding, > > > > + the second cell for the address offset within the window. > > > > + > > > > +- size-cells: Must be '1'. > > > > + > > > > +- ranges: Must be set up to provide a proper translation for each child. > > > > + See the examples below. > > > > > > You should explain here what the policy is regarding windows set up by the > > > boot loader. Are the ranges in here required to be the ones that the boot > > > loader has preconfigured, or are they the ones that the mbus driver is supposed > > > to set up? > > > > > > > Actually, I might be confused but the kernel MBus driver is completely > > independent from the bootloader's -except in the internal register case, > > (because we don't touch that from where the bootloader left it). > > Right, then state that clearly in the binding. > > > What happens is that any decoding window that was setup by the bootloader, > > is wiped and completely new windows are allocated using the translations > > in the DT, as described by this binding. > > > > This was the case from the start with the old MBus driver. FWIW, I think > > it's actually the best choice that can be made: it makes the kernel > > independent of the previous setting. > > > > I know you've suggested differently in the past, but I'm not sure I > > understand what's the benefit in keeping the bootloaders configuration. > > The device tree /normally/ describes things that are either wired up > in hardware or set up by the boot loader. Describing things that the > boot loader may or may not have set up and that the kernel should > set up but may ignore if it wants to is a bit fishy, but it seems > that you have decided to do it that way. You should definitely > document the fact that all ranges except the "internal-regs" are just > suggestions and cannot be relied on to be present at boot time. > Hold on! I've just noticed this, and I want to clarify something, just to avoid mis-interpretations. The binding is not saying "the windows described through this ranges are present at boot time". Rather, it is "this binding will guarantee that the windows described in it will be present after the mbus allocates them". Does it sound too fishy? -- Ezequiel Garc?a, Free Electrons Embedded Linux, Kernel and Android Engineering http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ezequiel Garcia Subject: Re: [PATCH v3 03/12] bus: mvebu-mbus: Add static window allocation to the DT binding Date: Wed, 19 Jun 2013 15:52:25 -0300 Message-ID: <20130619185224.GB5701@localhost> References: <1371554737-25319-1-git-send-email-ezequiel.garcia@free-electrons.com> <201306181814.33941.arnd@arndb.de> <20130618213454.GD2516@localhost> <201306182345.26281.arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <201306182345.26281.arnd-r2nGTMty4D4@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Arnd Bergmann Cc: Andrew Lunn , Jason Cooper , devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, Jason Gunthorpe , Maen Suleiman , Lior Amsalem , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Sebastian Hesselbarth List-Id: devicetree@vger.kernel.org SGkgQXJuZCwKCk9uIFR1ZSwgSnVuIDE4LCAyMDEzIGF0IDExOjQ1OjI2UE0gKzAyMDAsIEFybmQg QmVyZ21hbm4gd3JvdGU6Cj4gT24gVHVlc2RheSAxOCBKdW5lIDIwMTMsIEV6ZXF1aWVsIEdhcmNp YSB3cm90ZToKPiA+IE9uIFR1ZSwgSnVuIDE4LCAyMDEzIGF0IDA2OjE0OjMzUE0gKzAyMDAsIEFy bmQgQmVyZ21hbm4gd3JvdGU6Cj4gPiA+IE9uIFR1ZXNkYXkgMTggSnVuZSAyMDEzLCBFemVxdWll bCBHYXJjaWEgd3JvdGU6Cj4gPiA+ID4gK1JlcXVpcmVkIHByb3BlcnRpZXM6Cj4gPiA+ID4gKwo+ ID4gPiA+ICstIGNvbXBhdGlibGU6CSBTaG91bGQgYmUgc2V0IHRvIG9uZSBvZiB0aGUgZm9sbG93 aW5nOgo+ID4gPiA+ICsJCSBtYXJ2ZWxsLGFybWFkYTM3MC1tYnVzCj4gPiA+ID4gKwkJIG1hcnZl bGwsYXJtYWRheHAtbWJ1cwo+ID4gPiA+ICsKPiA+ID4gPiArLSByZWc6CQkgRGV2aWNlJ3MgcmVn aXN0ZXIgc3BhY2UuCj4gPiA+ID4gKwkJIFR3byBlbnRyaWVzIGFyZSBleHBlY3RlZCwgc2VlIHRo ZSBleGFtcGxlcyBiZWxvdy4KPiA+ID4gPiArCQkgVGhlIGZpcnN0IG9uZSBjb250cm9scyB0aGUg ZGV2aWNlcyBkZWNvZGluZyB3aW5kb3cgYW5kCj4gPiA+ID4gKwkJIHRoZSBzZWNvbmQgb25lIGNv bnRyb2xzIHRoZSBTRFJBTSBkZWNvZGluZyB3aW5kb3cuCj4gPiA+ID4gKwo+ID4gPiA+ICstIGFk ZHJlc3MtY2VsbHM6IE11c3QgYmUgJzInLiBUaGUgZmlyc3QgY2VsbCBmb3IgdGhlIE1CdXMgSUQg ZW5jb2RpbmcsCj4gPiA+ID4gKyAgICAgICAgICAgICAgICAgdGhlIHNlY29uZCBjZWxsIGZvciB0 aGUgYWRkcmVzcyBvZmZzZXQgd2l0aGluIHRoZSB3aW5kb3cuCj4gPiA+ID4gKwo+ID4gPiA+ICst IHNpemUtY2VsbHM6ICAgIE11c3QgYmUgJzEnLgo+ID4gPiA+ICsKPiA+ID4gPiArLSByYW5nZXM6 ICAgICAgICBNdXN0IGJlIHNldCB1cCB0byBwcm92aWRlIGEgcHJvcGVyIHRyYW5zbGF0aW9uIGZv ciBlYWNoIGNoaWxkLgo+ID4gPiA+ICsJICAgICAgICAgU2VlIHRoZSBleGFtcGxlcyBiZWxvdy4K PiA+ID4gCj4gPiA+IFlvdSBzaG91bGQgZXhwbGFpbiBoZXJlIHdoYXQgdGhlIHBvbGljeSBpcyBy ZWdhcmRpbmcgd2luZG93cyBzZXQgdXAgYnkgdGhlCj4gPiA+IGJvb3QgbG9hZGVyLiBBcmUgdGhl IHJhbmdlcyBpbiBoZXJlIHJlcXVpcmVkIHRvIGJlIHRoZSBvbmVzIHRoYXQgdGhlIGJvb3QKPiA+ ID4gbG9hZGVyIGhhcyBwcmVjb25maWd1cmVkLCBvciBhcmUgdGhleSB0aGUgb25lcyB0aGF0IHRo ZSBtYnVzIGRyaXZlciBpcyBzdXBwb3NlZAo+ID4gPiB0byBzZXQgdXA/Cj4gPiA+IAo+ID4gCj4g PiBBY3R1YWxseSwgSSBtaWdodCBiZSBjb25mdXNlZCBidXQgdGhlIGtlcm5lbCBNQnVzIGRyaXZl ciBpcyBjb21wbGV0ZWx5Cj4gPiBpbmRlcGVuZGVudCBmcm9tIHRoZSBib290bG9hZGVyJ3MgLWV4 Y2VwdCBpbiB0aGUgaW50ZXJuYWwgcmVnaXN0ZXIgY2FzZSwKPiA+IChiZWNhdXNlIHdlIGRvbid0 IHRvdWNoIHRoYXQgZnJvbSB3aGVyZSB0aGUgYm9vdGxvYWRlciBsZWZ0IGl0KS4KPiAKPiBSaWdo dCwgdGhlbiBzdGF0ZSB0aGF0IGNsZWFybHkgaW4gdGhlIGJpbmRpbmcuCj4gCj4gPiBXaGF0IGhh cHBlbnMgaXMgdGhhdCBhbnkgZGVjb2Rpbmcgd2luZG93IHRoYXQgd2FzIHNldHVwIGJ5IHRoZSBi b290bG9hZGVyLAo+ID4gaXMgd2lwZWQgYW5kIGNvbXBsZXRlbHkgbmV3IHdpbmRvd3MgYXJlIGFs bG9jYXRlZCB1c2luZyB0aGUgdHJhbnNsYXRpb25zCj4gPiBpbiB0aGUgRFQsIGFzIGRlc2NyaWJl ZCBieSB0aGlzIGJpbmRpbmcuCj4gPiAKPiA+IFRoaXMgd2FzIHRoZSBjYXNlIGZyb20gdGhlIHN0 YXJ0IHdpdGggdGhlIG9sZCBNQnVzIGRyaXZlci4gRldJVywgSSB0aGluawo+ID4gaXQncyBhY3R1 YWxseSB0aGUgYmVzdCBjaG9pY2UgdGhhdCBjYW4gYmUgbWFkZTogaXQgbWFrZXMgdGhlIGtlcm5l bAo+ID4gaW5kZXBlbmRlbnQgb2YgdGhlIHByZXZpb3VzIHNldHRpbmcuCj4gPiAKPiA+IEkga25v dyB5b3UndmUgc3VnZ2VzdGVkIGRpZmZlcmVudGx5IGluIHRoZSBwYXN0LCBidXQgSSdtIG5vdCBz dXJlIEkKPiA+IHVuZGVyc3RhbmQgd2hhdCdzIHRoZSBiZW5lZml0IGluIGtlZXBpbmcgdGhlIGJv b3Rsb2FkZXJzIGNvbmZpZ3VyYXRpb24uCj4gCj4gVGhlIGRldmljZSB0cmVlIC9ub3JtYWxseS8g ZGVzY3JpYmVzIHRoaW5ncyB0aGF0IGFyZSBlaXRoZXIgd2lyZWQgdXAKPiBpbiBoYXJkd2FyZSBv ciBzZXQgdXAgYnkgdGhlIGJvb3QgbG9hZGVyLiBEZXNjcmliaW5nIHRoaW5ncyB0aGF0IHRoZQo+ IGJvb3QgbG9hZGVyIG1heSBvciBtYXkgbm90IGhhdmUgc2V0IHVwIGFuZCB0aGF0IHRoZSBrZXJu ZWwgc2hvdWxkCj4gc2V0IHVwIGJ1dCBtYXkgaWdub3JlIGlmIGl0IHdhbnRzIHRvIGlzIGEgYml0 IGZpc2h5LCBidXQgaXQgc2VlbXMKPiB0aGF0IHlvdSBoYXZlIGRlY2lkZWQgdG8gZG8gaXQgdGhh dCB3YXkuIFlvdSBzaG91bGQgZGVmaW5pdGVseQo+IGRvY3VtZW50IHRoZSBmYWN0IHRoYXQgYWxs IHJhbmdlcyBleGNlcHQgdGhlICJpbnRlcm5hbC1yZWdzIiBhcmUganVzdAo+IHN1Z2dlc3Rpb25z IGFuZCBjYW5ub3QgYmUgcmVsaWVkIG9uIHRvIGJlIHByZXNlbnQgYXQgYm9vdCB0aW1lLgo+IAoK SG9sZCBvbiEgSSd2ZSBqdXN0IG5vdGljZWQgdGhpcywgYW5kIEkgd2FudCB0byBjbGFyaWZ5IHNv bWV0aGluZywganVzdAp0byBhdm9pZCBtaXMtaW50ZXJwcmV0YXRpb25zLiBUaGUgYmluZGluZyBp cyBub3Qgc2F5aW5nICJ0aGUgd2luZG93cwpkZXNjcmliZWQgdGhyb3VnaCB0aGlzIHJhbmdlcyBh cmUgcHJlc2VudCBhdCBib290IHRpbWUiLgoKUmF0aGVyLCBpdCBpcyAidGhpcyBiaW5kaW5nIHdp bGwgZ3VhcmFudGVlIHRoYXQgdGhlIHdpbmRvd3MgZGVzY3JpYmVkIAppbiBpdCB3aWxsIGJlIHBy ZXNlbnQgYWZ0ZXIgdGhlIG1idXMgYWxsb2NhdGVzIHRoZW0iLgoKRG9lcyBpdCBzb3VuZCB0b28g ZmlzaHk/Ci0tIApFemVxdWllbCBHYXJjw61hLCBGcmVlIEVsZWN0cm9ucwpFbWJlZGRlZCBMaW51 eCwgS2VybmVsIGFuZCBBbmRyb2lkIEVuZ2luZWVyaW5nCmh0dHA6Ly9mcmVlLWVsZWN0cm9ucy5j b20KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZGV2aWNl dHJlZS1kaXNjdXNzIG1haWxpbmcgbGlzdApkZXZpY2V0cmVlLWRpc2N1c3NAbGlzdHMub3psYWJz Lm9yZwpodHRwczovL2xpc3RzLm96bGFicy5vcmcvbGlzdGluZm8vZGV2aWNldHJlZS1kaXNjdXNz Cg==