From: Ben Myers <bpm@sgi.com>
To: Jeff Liu <jeff.liu@oracle.com>
Cc: "xfs@oss.sgi.com" <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfs: Remove two dead transaction log reservaion macros
Date: Wed, 19 Jun 2013 14:27:01 -0500 [thread overview]
Message-ID: <20130619192701.GQ20932@sgi.com> (raw)
In-Reply-To: <51836A1F.2020804@oracle.com>
On Fri, May 03, 2013 at 03:41:19PM +0800, Jeff Liu wrote:
> From: Jie Liu <jeff.liu@oracle.com>
>
> Upstream commit 5b292ae3a951a58e32119d73c7ac8f5bec7395a3
> xfs: make use of xfs_calc_buf_res() in xfs_trans.c
>
> Beginning from above commit, neither XFS_ALLOCFREE_LOG_RES() nor
> XFS_DIROP_LOG_RES() is used by those routines for calculating
> transaction space reservations, so it's safe to remove them now.
>
> Also, with a slightly update for the relevant comments to reflect
> the ideas of why those log count numbers should be.
>
> Signed-off-by: Jie Liu <jeff.liu@oracle.com>
Looks good. Applied.
Reviewed-by: Ben Myers <bpm@sgi.com>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2013-06-19 19:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-03 7:41 [PATCH] xfs: Remove two dead transaction log reservaion macros Jeff Liu
2013-06-19 19:27 ` Ben Myers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130619192701.GQ20932@sgi.com \
--to=bpm@sgi.com \
--cc=jeff.liu@oracle.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.