From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Date: Thu, 20 Jun 2013 02:40:18 +0000 Subject: Re: [lm-sensors] [PATCH v2] hwmon: (ina2xx) Add device tree support to pass the shunt resistor Message-Id: <20130620024018.GA835@roeck-us.net> List-Id: References: <1371624620-14254-1-git-send-email-Yuantian.Tang@freescale.com> <20130619154310.GA29516@roeck-us.net> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Tang Yuantian-B29983 Cc: "khali@linux-fr.org" , "lm-sensors@lm-sensors.org" , "devicetree-discuss@lists.ozlabs.org" , "linux-doc@vger.kernel.org" T24gVGh1LCBKdW4gMjAsIDIwMTMgYXQgMDI6Mjc6MThBTSArMDAwMCwgVGFuZyBZdWFudGlhbi1C Mjk5ODMgd3JvdGU6Cj4gCj4gCj4gPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQo+ID4gRnJv bTogR3VlbnRlciBSb2VjayBbbWFpbHRvOmxpbnV4QHJvZWNrLXVzLm5ldF0KPiA+IFNlbnQ6IDIw MTPlubQ25pyIMTnml6Ug5pif5pyf5LiJIDIzOjQzCj4gPiBUbzogVGFuZyBZdWFudGlhbi1CMjk5 ODMKPiA+IENjOiBraGFsaUBsaW51eC1mci5vcmc7IGxtLXNlbnNvcnNAbG0tc2Vuc29ycy5vcmc7 IGRldmljZXRyZWUtCj4gPiBkaXNjdXNzQGxpc3RzLm96bGFicy5vcmc7IGxpbnV4LWRvY0B2Z2Vy Lmtlcm5lbC5vcmcKPiA+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggdjJdIGh3bW9uOiAoaW5hMnh4KSBB ZGQgZGV2aWNlIHRyZWUgc3VwcG9ydCB0byBwYXNzCj4gPiB0aGUgc2h1bnQgcmVzaXN0b3IKPiA+ IAo+ID4gT24gV2VkLCBKdW4gMTksIDIwMTMgYXQgMDI6NTA6MjBQTSArMDgwMCwgWXVhbnRpYW4u VGFuZ0BmcmVlc2NhbGUuY29tCj4gPiB3cm90ZToKPiA+ID4gRnJvbTogVGFuZyBZdWFudGlhbiA8 eXVhbnRpYW4udGFuZ0BmcmVlc2NhbGUuY29tPgo+ID4gPgo+ID4gPiBBZGRpbmcgYW5vdGhlciB3 YXkgdGhhdCBpcyBkZXZpY2UgdHJlZSB0byBwYXNzIHRoZSBzaHVudCByZXNpc3Rvcgo+ID4gPiB2 YWx1ZSB0byBkcml2ZXIgZXhjZXB0IGZvciBwbGF0Zm9ybSBkYXRhLgo+ID4gPgo+ID4gPiBTaWdu ZWQtb2ZmLWJ5OiBUYW5nIFl1YW50aWFuIDxZdWFudGlhbi5UYW5nQGZyZWVzY2FsZS5jb20+Cj4g PiAKPiA+IEkgbm90aWNlZCB0aGF0IG9mLmggaW5jbHVkZSB3YXMgbWlzc2luZy4gTm8gbmVlZCB0 byByZS1zZW5kOyBJIGFkZGVkIGl0Cj4gPiBteXNlbGYuCj4gPiBBcHBsaWVkIHRvIC1uZXh0Lgo+ ID4gCj4gCj4gVGhhbmtzIGZvciB5b3VyIGhlbHAuIE9mLmggaXMgYWxyZWFkeSBpbmNsdWRlZCBp biBpMmMuaC4KPiBJZiBpdCBpcyByZWFsbHkgbmVlZGVkLCBJIHNob3VsZCBoYXZlIHNlZW4gdGhl IHdhcm5pbmcgb3IgZXJyb3Igd2hlbiBjb21waWxlLgo+IEluY2x1ZGluZyBpdCBleHBsaWNpdGx5 IGlzIGFsc28gYSBnb29kIHBvaW50Lgo+IApDb21tb24gcnVsZSBpcyB0byBpbmNsdWRlIGEgZmls ZSBpZiBpdHMgZGVmaW5pdGlvbnMgYXJlIHVzZWQuIFdlIGNhbiBub3QgcmVseQpvbiBzb21lIG90 aGVyIGZpbGUgaW5jbHVkaW5nIGl0IGZvciB1cywgc2luY2UgaXQgaXMgbm90IGd1YXJhbnRlZWQg dGhhdCB0aGlzCndpbGwgYWx3YXlzIGJlIHRoZSBjYXNlLgoKVGhhbmtzLApHdWVudGVyCgpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsbS1zZW5zb3JzIG1h aWxpbmcgbGlzdApsbS1zZW5zb3JzQGxtLXNlbnNvcnMub3JnCmh0dHA6Ly9saXN0cy5sbS1zZW5z b3JzLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xtLXNlbnNvcnM From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Subject: Re: [PATCH v2] hwmon: (ina2xx) Add device tree support to pass the shunt resistor Date: Wed, 19 Jun 2013 19:40:18 -0700 Message-ID: <20130620024018.GA835@roeck-us.net> References: <1371624620-14254-1-git-send-email-Yuantian.Tang@freescale.com> <20130619154310.GA29516@roeck-us.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-doc-owner@vger.kernel.org To: Tang Yuantian-B29983 Cc: "khali@linux-fr.org" , "lm-sensors@lm-sensors.org" , "devicetree-discuss@lists.ozlabs.org" , "linux-doc@vger.kernel.org" List-Id: devicetree@vger.kernel.org On Thu, Jun 20, 2013 at 02:27:18AM +0000, Tang Yuantian-B29983 wrote: >=20 >=20 > > -----Original Message----- > > From: Guenter Roeck [mailto:linux@roeck-us.net] > > Sent: 2013=E5=B9=B46=E6=9C=8819=E6=97=A5 =E6=98=9F=E6=9C=9F=E4=B8=89= 23:43 > > To: Tang Yuantian-B29983 > > Cc: khali@linux-fr.org; lm-sensors@lm-sensors.org; devicetree- > > discuss@lists.ozlabs.org; linux-doc@vger.kernel.org > > Subject: Re: [PATCH v2] hwmon: (ina2xx) Add device tree support to = pass > > the shunt resistor > >=20 > > On Wed, Jun 19, 2013 at 02:50:20PM +0800, Yuantian.Tang@freescale.c= om > > wrote: > > > From: Tang Yuantian > > > > > > Adding another way that is device tree to pass the shunt resistor > > > value to driver except for platform data. > > > > > > Signed-off-by: Tang Yuantian > >=20 > > I noticed that of.h include was missing. No need to re-send; I adde= d it > > myself. > > Applied to -next. > >=20 >=20 > Thanks for your help. Of.h is already included in i2c.h. > If it is really needed, I should have seen the warning or error when = compile. > Including it explicitly is also a good point. >=20 Common rule is to include a file if its definitions are used. We can no= t rely on some other file including it for us, since it is not guaranteed that= this will always be the case. Thanks, Guenter