All of lore.kernel.org
 help / color / mirror / Atom feed
From: mingo@kernel.org (Ingo Molnar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] perf: arm64: Record the user-mode PC in the call chain.
Date: Thu, 20 Jun 2013 10:33:28 +0200	[thread overview]
Message-ID: <20130620083327.GA5288@gmail.com> (raw)
In-Reply-To: <20130620030713.GA27428@mozilla.com>


* Jed Davis <jld@mozilla.com> wrote:

> With this change, we no longer lose the innermost entry in the user-mode
> part of the call chain.  See also the x86 port, which includes the ip,
> and the corresponding change in arch/arm.
> 
> Signed-off-by: Jed Davis <jld@mozilla.com>
> ---
>  arch/arm64/kernel/perf_event.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/kernel/perf_event.c b/arch/arm64/kernel/perf_event.c
> index 1e49e5eb..9ba33c4 100644
> --- a/arch/arm64/kernel/perf_event.c
> +++ b/arch/arm64/kernel/perf_event.c
> @@ -1336,6 +1336,7 @@ void perf_callchain_user(struct perf_callchain_entry *entry,
>  		return;
>  	}
>  
> +	perf_callchain_store(entry, regs->pc);
>  	tail = (struct frame_tail __user *)regs->regs[29];
>  
>  	while (entry->nr < PERF_MAX_STACK_DEPTH &&

Acked-by: Ingo Molnar <mingo@kernel.org>

I suspect this goes to v3.10 via the ARM64 tree?

Thanks,

	Ingo

WARNING: multiple messages have this Message-ID (diff)
From: Ingo Molnar <mingo@kernel.org>
To: Jed Davis <jld@mozilla.com>
Cc: linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Will Deacon <will.deacon@arm.com>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@redhat.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Subject: Re: [PATCH] perf: arm64: Record the user-mode PC in the call chain.
Date: Thu, 20 Jun 2013 10:33:28 +0200	[thread overview]
Message-ID: <20130620083327.GA5288@gmail.com> (raw)
In-Reply-To: <20130620030713.GA27428@mozilla.com>


* Jed Davis <jld@mozilla.com> wrote:

> With this change, we no longer lose the innermost entry in the user-mode
> part of the call chain.  See also the x86 port, which includes the ip,
> and the corresponding change in arch/arm.
> 
> Signed-off-by: Jed Davis <jld@mozilla.com>
> ---
>  arch/arm64/kernel/perf_event.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/kernel/perf_event.c b/arch/arm64/kernel/perf_event.c
> index 1e49e5eb..9ba33c4 100644
> --- a/arch/arm64/kernel/perf_event.c
> +++ b/arch/arm64/kernel/perf_event.c
> @@ -1336,6 +1336,7 @@ void perf_callchain_user(struct perf_callchain_entry *entry,
>  		return;
>  	}
>  
> +	perf_callchain_store(entry, regs->pc);
>  	tail = (struct frame_tail __user *)regs->regs[29];
>  
>  	while (entry->nr < PERF_MAX_STACK_DEPTH &&

Acked-by: Ingo Molnar <mingo@kernel.org>

I suspect this goes to v3.10 via the ARM64 tree?

Thanks,

	Ingo

  reply	other threads:[~2013-06-20  8:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-20  3:07 [PATCH] perf: arm64: Record the user-mode PC in the call chain Jed Davis
2013-06-20  3:07 ` Jed Davis
2013-06-20  8:33 ` Ingo Molnar [this message]
2013-06-20  8:33   ` Ingo Molnar
2013-06-20  9:11   ` Will Deacon
2013-06-20  9:11     ` Will Deacon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130620083327.GA5288@gmail.com \
    --to=mingo@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.