From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH] drm: Improve manual IRQ installation documentation Date: Thu, 20 Jun 2013 12:10:47 +0200 Message-ID: <20130620101046.GA2596@manwe> References: <1371643245-8325-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1093099868==" Return-path: Received: from mail-bk0-f44.google.com (mail-bk0-f44.google.com [209.85.214.44]) by gabe.freedesktop.org (Postfix) with ESMTP id 306F4E5DE3 for ; Thu, 20 Jun 2013 03:10:51 -0700 (PDT) Received: by mail-bk0-f44.google.com with SMTP id r7so2788590bkg.3 for ; Thu, 20 Jun 2013 03:10:50 -0700 (PDT) In-Reply-To: <1371643245-8325-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Laurent Pinchart Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1093099868== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="cNdxnHkX5QqsyA0e" Content-Disposition: inline --cNdxnHkX5QqsyA0e Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jun 19, 2013 at 02:00:45PM +0200, Laurent Pinchart wrote: > Signed-off-by: Laurent Pinchart > --- > Documentation/DocBook/drm.tmpl | 14 ++++++++------ > 1 file changed, 8 insertions(+), 6 deletions(-) >=20 > diff --git a/Documentation/DocBook/drm.tmpl b/Documentation/DocBook/drm.t= mpl > index f9df3b8..738b727 100644 > --- a/Documentation/DocBook/drm.tmpl > +++ b/Documentation/DocBook/drm.tmpl > @@ -186,11 +186,12 @@ > > DRIVER_HAVE_IRQDRIVER_IRQ_SHARED > > - DRIVER_HAVE_IRQ indicates whether the driver has an IRQ ha= ndler. The > - DRM core will automatically register an interrupt handler = when the > - flag is set. DRIVER_IRQ_SHARED indicates whether the devic= e & > - handler support shared IRQs (note that this is required of= PCI > - drivers). > + DRIVER_HAVE_IRQ indicates whether the driver has an IRQ ha= ndler > + managed by the DRM Core. The core will support simple IRQ = handler > + installation when the flag is set. The installation proces= s is > + described in . > + DRIVER_IRQ_SHARED indicates whether the device &= handler > + support shared IRQs (note that this is required of PCI dr= ivers). > > > > @@ -344,7 +345,8 @@ char *date; > The DRM core tries to facilitate IRQ handler registration and > unregistration by providing drm_irq_install and > drm_irq_uninstall functions. Those functi= ons only > - support a single interrupt per device. > + support a single interrupt per device, devices that use more t= han one > + IRQs need to be handled manually. Perhaps this should mention that if you handle IRQ installation manually you also need to manually set drm->irq_enabled =3D 1, as otherwise things like DRM_IOCTL_WAIT_VBLANK won't work properly. Thierry --cNdxnHkX5QqsyA0e Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.20 (GNU/Linux) iQIcBAEBAgAGBQJRwtUmAAoJEN0jrNd/PrOhor0P/2Hlog45ziog77lfd8fqMrHp LgRWsiVI42FgqgOBHvTbU7wX8xzIr5iBTXNPrM5QkMWVCko0B49iGX5/zRIyoEd3 iYE7JveJrOgu6kpfkzPZ7e/JxZ0uK8zkWV7vn6DevUOQGltN8gWnQA69xCoUfwxW FUKHRssOUSN/i3Paz9zdJ2gZbP0acGD/150FDvZ4s7/pBWLL6UrySWqzfqS83vA3 yht14VojBAjJ63Jc5Z9u/JJQZAcHAiVJghdgu61GUlfP+NAF8AxsdHvNTrODT1p8 AAtxS+NwA0otJ1G2oP4Zy//mDHJcwjFcX8WVwxwsWjrEKPUSOd5H+nQMAw40Iw5q Y3w383RyETzrlTtIVev25ORplonF6Qdjrz4EOEV5dF9+w4tCDYBKh850RH7ko/is KtS+k23aOQJIK5l2A7T6yGFOT3cCgHXOFv7JTxsyYwD6/TxmK5qF5l4CMkr+scXx xCtuFeoXvUxvERU/wJs1ivaK8M89Gc1lWi7YsMCZFwEClxOJeqjYpMMCn6VFbdHO 1BqJisREI7WO/dgE5VSlsNJel3lFao+WqB4HrNVivwQcYTZBzQRhCmh25CidH6hZ F0HxUz5TqVOU0oLkw7Uokv4Zsaqmq8tBwJrsQjzqzJ0UWHljW90p29zLbW9Qsyor PNXivCrxQljQ0Gvot3N4 =M2eA -----END PGP SIGNATURE----- --cNdxnHkX5QqsyA0e-- --===============1093099868== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============1093099868==--