From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH -next] Revert "netfilter: tproxy: do not assign timewait sockets to skb->sk"
Date: Thu, 20 Jun 2013 12:22:34 +0200 [thread overview]
Message-ID: <20130620102234.GA19823@localhost> (raw)
In-Reply-To: <1369792719-3945-1-git-send-email-fw@strlen.de>
On Wed, May 29, 2013 at 03:58:39AM +0200, Florian Westphal wrote:
> This reverts commit d503b30bd648b3cb4e5f50b65d27e389960cc6d9.
>
> Nowadays we have early socket demux; all the input code paths
> should handle "skb->sk points to timewait sock" properly.
I'm fine with this but I think that we should have some nf_sock_put
definition somewhere else. Using the tproxy namespace from xt_socket
doesn't seem nice to me.
next prev parent reply other threads:[~2013-06-20 10:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-29 1:58 [PATCH -next] Revert "netfilter: tproxy: do not assign timewait sockets to skb->sk" Florian Westphal
2013-05-29 14:56 ` Eric Dumazet
2013-06-20 10:22 ` Pablo Neira Ayuso [this message]
2013-06-20 10:36 ` Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130620102234.GA19823@localhost \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.