From: Thierry Reding <thierry.reding@gmail.com>
To: Axel Lin <axel.lin@ingics.com>
Cc: Steffen Trumtrar <s.trumtrar@pengutronix.de>, linux-pwm@vger.kernel.org
Subject: Re: [PATCH] pwm: pca9685: Add .owner to struct pwm_ops
Date: Thu, 20 Jun 2013 13:02:50 +0200 [thread overview]
Message-ID: <20130620110249.GB28718@manwe> (raw)
In-Reply-To: <1371662009.5355.0.camel@phoenix>
[-- Attachment #1: Type: text/plain, Size: 919 bytes --]
On Thu, Jun 20, 2013 at 01:13:29AM +0800, Axel Lin wrote:
> Add missing .owner of struct pwm_ops. This prevents the module from being
> removed from underneath its users.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> drivers/pwm/pwm-pca9685.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pwm/pwm-pca9685.c b/drivers/pwm/pwm-pca9685.c
> index 2afc904..c9f9e65 100644
> --- a/drivers/pwm/pwm-pca9685.c
> +++ b/drivers/pwm/pwm-pca9685.c
> @@ -199,6 +199,7 @@ static const struct pwm_ops pca9685_pwm_ops = {
> .config = pca9685_pwm_config,
> .request = pca9685_pwm_request,
> .free = pca9685_pwm_free,
> + .owner = THIS_MODULE,
> };
>
> static struct regmap_config pca9685_regmap_i2c_config = {
Hi Axel,
I've already posted a patch for this (and a few other missing .owner
fields) a few days ago. I've now pushed it to my for-next branch.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2013-06-20 11:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-19 17:13 [PATCH] pwm: pca9685: Add .owner to struct pwm_ops Axel Lin
2013-06-20 11:02 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130620110249.GB28718@manwe \
--to=thierry.reding@gmail.com \
--cc=axel.lin@ingics.com \
--cc=linux-pwm@vger.kernel.org \
--cc=s.trumtrar@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.