From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gleb Natapov Subject: Re: Regression after "Remove support for reporting coalesced APIC IRQs" Date: Thu, 20 Jun 2013 14:47:45 +0300 Message-ID: <20130620114745.GH5832@redhat.com> References: <20130606085352.GZ4725@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org, yongjie.ren@intel.com To: Jan Kiszka Return-path: Received: from mx1.redhat.com ([209.132.183.28]:60935 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965327Ab3FTLrv (ORCPT ); Thu, 20 Jun 2013 07:47:51 -0400 Content-Disposition: inline In-Reply-To: <20130606085352.GZ4725@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Jan ping, are you OK with what I proposed below? On Thu, Jun 06, 2013 at 11:53:52AM +0300, Gleb Natapov wrote: > Hi Jan, > > I bisected [1] to f1ed0450a5fac7067590317cbf027f566b6ccbca. Fortunately > further investigation showed that it is not really related to removing > APIC timer interrupt reinjection and the real problem is that we cannot > assume that __apic_accept_irq() always injects interrupts like the patch > does because the function skips interrupt injection if APIC is disabled. > This misreporting screws RTC interrupt tracking, so further RTC interrupt > are stopped to be injected. The simplest solution that I see is to revert > most of the commit and only leave APIC timer interrupt reinjection. > > If you have more elegant solution let me know. > > [1] https://bugzilla.kernel.org/show_bug.cgi?id=58931 > -- > Gleb. > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Gleb.