From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from moutng.kundenserver.de ([212.227.17.10]:58297 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965039Ab3FTNVt (ORCPT ); Thu, 20 Jun 2013 09:21:49 -0400 From: Arnd Bergmann To: Jingoo Han Subject: Re: [PATCH V8 1/4] pci: Add PCIe driver for Samsung Exynos Date: Thu, 20 Jun 2013 15:20:48 +0200 Cc: "'Kukjin Kim'" , "'Bjorn Helgaas'" , linux-samsung-soc@vger.kernel.org, linux-pci@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, "'Grant Likely'" , "'Andrew Murray'" , "'Thomas Petazzoni'" , "'Thierry Reding'" , "'Jason Gunthorpe'" , "'Surendranath Gurivireddy Balla'" , "'Siva Reddy Kallam'" , "'Thomas Abraham'" , "'Tomasz Figa'" , "'Pratyush Anand'" , "'Mohit KUMAR'" References: <00db01ce6db3$7f9a3830$7ecea890$@samsung.com> In-Reply-To: <00db01ce6db3$7f9a3830$7ecea890$@samsung.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Message-Id: <201306201520.49212.arnd@arndb.de> Sender: linux-pci-owner@vger.kernel.org List-ID: On Thursday 20 June 2013, Jingoo Han wrote: > diff --git a/Documentation/devicetree/bindings/pci/exynos-pcie.txt b/Documentation/devicetree/bindings/pci/exynos-pcie.txt > new file mode 100644 > index 0000000..f71d835 > --- /dev/null > +++ b/Documentation/devicetree/bindings/pci/exynos-pcie.txt > @@ -0,0 +1,73 @@ > +* Samsung Exynos PCIe interface Please adapt the name of the binding as well, and name it snps-dwc-pcie.txt for instance, to match the change in the driver and in the binding. > +Required properties: > +-compatible: should contain "snps,dwc-pcie" to identify the > + core, plus an identifier for the specific instance, such > + as "samsung,exynos5440-pcie". Thanks for changing it here. > + > + pcie@290000 { > + compatible = "samsung,exynos5440-pcie"; > + reg = <0x290000 0x1000 > + 0x270000 0x1000 > + 0x271000 0x40>; but please also change the example and the .dts files to match. It should say here compatible = "samsung,exynos5440-pcie", "snps,dwc-pcie"; as now required by the binding. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH V8 1/4] pci: Add PCIe driver for Samsung Exynos Date: Thu, 20 Jun 2013 15:20:48 +0200 Message-ID: <201306201520.49212.arnd@arndb.de> References: <00db01ce6db3$7f9a3830$7ecea890$@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <00db01ce6db3$7f9a3830$7ecea890$@samsung.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Jingoo Han Cc: 'Thomas Petazzoni' , 'Jason Gunthorpe' , linux-samsung-soc@vger.kernel.org, 'Siva Reddy Kallam' , 'Surendranath Gurivireddy Balla' , linux-pci@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, 'Thierry Reding' , linux-kernel@vger.kernel.org, 'Grant Likely' , 'Kukjin Kim' , 'Thomas Abraham' , 'Mohit KUMAR' , 'Bjorn Helgaas' , 'Andrew Murray' , 'Pratyush Anand' , 'Tomasz Figa' , linux-arm-kernel@lists.infradead.org List-Id: linux-samsung-soc@vger.kernel.org On Thursday 20 June 2013, Jingoo Han wrote: > diff --git a/Documentation/devicetree/bindings/pci/exynos-pcie.txt b/Documentation/devicetree/bindings/pci/exynos-pcie.txt > new file mode 100644 > index 0000000..f71d835 > --- /dev/null > +++ b/Documentation/devicetree/bindings/pci/exynos-pcie.txt > @@ -0,0 +1,73 @@ > +* Samsung Exynos PCIe interface Please adapt the name of the binding as well, and name it snps-dwc-pcie.txt for instance, to match the change in the driver and in the binding. > +Required properties: > +-compatible: should contain "snps,dwc-pcie" to identify the > + core, plus an identifier for the specific instance, such > + as "samsung,exynos5440-pcie". Thanks for changing it here. > + > + pcie@290000 { > + compatible = "samsung,exynos5440-pcie"; > + reg = <0x290000 0x1000 > + 0x270000 0x1000 > + 0x271000 0x40>; but please also change the example and the .dts files to match. It should say here compatible = "samsung,exynos5440-pcie", "snps,dwc-pcie"; as now required by the binding. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Thu, 20 Jun 2013 15:20:48 +0200 Subject: [PATCH V8 1/4] pci: Add PCIe driver for Samsung Exynos In-Reply-To: <00db01ce6db3$7f9a3830$7ecea890$@samsung.com> References: <00db01ce6db3$7f9a3830$7ecea890$@samsung.com> Message-ID: <201306201520.49212.arnd@arndb.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thursday 20 June 2013, Jingoo Han wrote: > diff --git a/Documentation/devicetree/bindings/pci/exynos-pcie.txt b/Documentation/devicetree/bindings/pci/exynos-pcie.txt > new file mode 100644 > index 0000000..f71d835 > --- /dev/null > +++ b/Documentation/devicetree/bindings/pci/exynos-pcie.txt > @@ -0,0 +1,73 @@ > +* Samsung Exynos PCIe interface Please adapt the name of the binding as well, and name it snps-dwc-pcie.txt for instance, to match the change in the driver and in the binding. > +Required properties: > +-compatible: should contain "snps,dwc-pcie" to identify the > + core, plus an identifier for the specific instance, such > + as "samsung,exynos5440-pcie". Thanks for changing it here. > + > + pcie at 290000 { > + compatible = "samsung,exynos5440-pcie"; > + reg = <0x290000 0x1000 > + 0x270000 0x1000 > + 0x271000 0x40>; but please also change the example and the .dts files to match. It should say here compatible = "samsung,exynos5440-pcie", "snps,dwc-pcie"; as now required by the binding. Arnd