From mboxrd@z Thu Jan 1 00:00:00 1970 From: mpa@pengutronix.de (Markus Pargmann) Date: Thu, 20 Jun 2013 17:42:51 +0200 Subject: [PATCH 1/6] ARM: mx27: Replace clk_register_clkdev with clock DT lookup In-Reply-To: References: <1371739815-6666-1-git-send-email-mpa@pengutronix.de> <1371739815-6666-2-git-send-email-mpa@pengutronix.de> <1371742088.528552668@f66.mail.ru> Message-ID: <20130620154251.GC8219@s25.your-server.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Jun 20, 2013 at 12:35:10PM -0300, Fabio Estevam wrote: > On Thu, Jun 20, 2013 at 12:28 PM, Alexander Shiyan wrote: > >> From: Fabio Estevam > >> > >> Similarly as it was done for mx6q, use a DT lookup in order to make maintainance > >> task for the clock devices easier. > >> > >> Signed-off-by: Fabio Estevam > >> [Markus Pargmann: Add gpio clocks] > >> Signed-off-by: Markus Pargmann > >> --- > >> arch/arm/boot/dts/imx27.dtsi | 12 ++++++++++++ > >> 1 file changed, 12 insertions(+) > >> > >> diff --git a/arch/arm/boot/dts/imx27.dtsi b/arch/arm/boot/dts/imx27.dtsi > >> index 0695264..48c263c 100644 > >> --- a/arch/arm/boot/dts/imx27.dtsi > >> +++ b/arch/arm/boot/dts/imx27.dtsi > >> @@ -208,6 +208,8 @@ > >> #gpio-cells = <2>; > >> interrupt-controller; > >> #interrupt-cells = <2>; > >> + clocks = <&clks 47>; > >> + clock-names = "ipg"; > > > > Clock is not used in the gpio driver, so I doubt the usefulness of this patch. > > I think you meant "this hunk", right? > > My original patch did not have this part. It was added by Markus as > mentioned in the commit log, and I agree we should go with the > original version that did not add the gpio clock. I somehow missed that your patch was applied in march. gpio clocks are not mentioned in the binding documentation, so I drop this one completely. Thanks, Markus -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | From mboxrd@z Thu Jan 1 00:00:00 1970 From: Markus Pargmann Subject: Re: [PATCH 1/6] ARM: mx27: Replace clk_register_clkdev with clock DT lookup Date: Thu, 20 Jun 2013 17:42:51 +0200 Message-ID: <20130620154251.GC8219@s25.your-server.de> References: <1371739815-6666-1-git-send-email-mpa@pengutronix.de> <1371739815-6666-2-git-send-email-mpa@pengutronix.de> <1371742088.528552668@f66.mail.ru> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Fabio Estevam Cc: Fabio Estevam , Alexander Shiyan , devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, Sascha Hauer , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org On Thu, Jun 20, 2013 at 12:35:10PM -0300, Fabio Estevam wrote: > On Thu, Jun 20, 2013 at 12:28 PM, Alexander Shiyan wrote: > >> From: Fabio Estevam > >> > >> Similarly as it was done for mx6q, use a DT lookup in order to make maintainance > >> task for the clock devices easier. > >> > >> Signed-off-by: Fabio Estevam > >> [Markus Pargmann: Add gpio clocks] > >> Signed-off-by: Markus Pargmann > >> --- > >> arch/arm/boot/dts/imx27.dtsi | 12 ++++++++++++ > >> 1 file changed, 12 insertions(+) > >> > >> diff --git a/arch/arm/boot/dts/imx27.dtsi b/arch/arm/boot/dts/imx27.dtsi > >> index 0695264..48c263c 100644 > >> --- a/arch/arm/boot/dts/imx27.dtsi > >> +++ b/arch/arm/boot/dts/imx27.dtsi > >> @@ -208,6 +208,8 @@ > >> #gpio-cells = <2>; > >> interrupt-controller; > >> #interrupt-cells = <2>; > >> + clocks = <&clks 47>; > >> + clock-names = "ipg"; > > > > Clock is not used in the gpio driver, so I doubt the usefulness of this patch. > > I think you meant "this hunk", right? > > My original patch did not have this part. It was added by Markus as > mentioned in the commit log, and I agree we should go with the > original version that did not add the gpio clock. I somehow missed that your patch was applied in march. gpio clocks are not mentioned in the binding documentation, so I drop this one completely. Thanks, Markus -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |