From: thomas.petazzoni@free-electrons.com (Thomas Petazzoni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 02/10] ARM: fixup_pv_table bug when CPU_ENDIAN_BE8
Date: Thu, 20 Jun 2013 18:09:54 +0200 [thread overview]
Message-ID: <20130620180954.7448d824@skate> (raw)
In-Reply-To: <51C2DF82.3030404@codethink.co.uk>
Dear Ben Dooks,
On Thu, 20 Jun 2013 11:54:58 +0100, Ben Dooks wrote:
> > Also in
> > http://lists.infradead.org/pipermail/linux-arm-kernel/2013-February/150784.html,
> > the same reviewer suggested to name the macro BE8() to make it fit like
> > ARM() and THUMB() in the margin left by the indentation of assembly
> > code. And also to add LE() to make the above code look like:
> >
> > BE8( bic ip, ip, #0xff000000)
> > BE8( orr ip, ip, r6, lsl#24)
> > LE( bic ip, ip, #0x000000ff)
> > LE( orr ip, ip, r6)
>
> Actually, that doesn't work as LE is not the inverse of BE8 as
> it could also be when the kernel is being compiled in BE32.
Aah, correct. In BE32, data and instructions have the same endianness.
Thanks,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2013-06-20 16:09 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-19 12:36 Initial big-endian support series Ben Dooks
2013-06-19 12:36 ` [PATCH 01/10] ARM: fix ARCH_IXP4xx usage of ARCH_SUPPORTS_BIG_ENDIAN Ben Dooks
2013-06-19 17:30 ` Thomas Petazzoni
2013-06-20 11:07 ` Ben Dooks
2013-06-19 12:36 ` [PATCH 02/10] ARM: fixup_pv_table bug when CPU_ENDIAN_BE8 Ben Dooks
2013-06-19 17:33 ` Thomas Petazzoni
2013-06-20 10:54 ` Ben Dooks
2013-06-20 16:09 ` Thomas Petazzoni [this message]
2013-06-19 12:36 ` [PATCH 03/10] ARM: asm: Add ARM_BE8() assembly helper Ben Dooks
2013-06-19 12:36 ` [PATCH 04/10] ARM: set BE8 if LE in head code Ben Dooks
2013-06-19 12:36 ` [PATCH 05/10] ARM: pl01x debug code endian fix Ben Dooks
2013-06-19 12:36 ` [PATCH 06/10] ARM: twd: data " Ben Dooks
2013-06-19 12:36 ` [PATCH 07/10] ARM: smp_scu: data endian fixes Ben Dooks
2013-06-19 12:36 ` [PATCH 08/10] highbank: enable big-endian Ben Dooks
2013-06-19 12:36 ` [PATCH 09/10] mvebu: support running big-endian Ben Dooks
2013-06-19 12:36 ` [PATCH 10/10] vexpress: add big endian support Ben Dooks
2013-06-20 16:12 ` Initial big-endian support series Thomas Petazzoni
2013-06-27 17:16 ` Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130620180954.7448d824@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.