From: Heiko Voigt <hvoigt@hvoigt.net>
To: Fredrik Gustafsson <iveqy@iveqy.com>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH] [submodule] Remove duplicate call to set_rev_name
Date: Thu, 20 Jun 2013 23:58:12 +0200 [thread overview]
Message-ID: <20130620215812.GA2687@sandbox-ub> (raw)
In-Reply-To: <1371462936-9672-1-git-send-email-iveqy@iveqy.com>
Hi,
On Mon, Jun 17, 2013 at 11:55:36AM +0200, Fredrik Gustafsson wrote:
> set_rev_name is a possible expensive operation. If a submodule has
> changes in it, set_rev_name was called twice.
>
> Solution is to move set_rev_name so it's only called once, no matter the
> codepath taken.
Looks good to me.
Cheers Heiko
next prev parent reply other threads:[~2013-06-20 22:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-17 9:55 [PATCH] [submodule] Remove duplicate call to set_rev_name Fredrik Gustafsson
2013-06-20 21:58 ` Heiko Voigt [this message]
2013-06-21 17:03 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130620215812.GA2687@sandbox-ub \
--to=hvoigt@hvoigt.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=iveqy@iveqy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.