From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arm: fix memory coherency problem after relocation
Date: Thu, 20 Jun 2013 22:19:20 +0200 [thread overview]
Message-ID: <201306202219.20646.marex@denx.de> (raw)
In-Reply-To: <51C33600.2070103@newsguy.com>
Dear Mike Dunn,
> On 06/20/2013 06:56 AM, Marek Vasut wrote:
> > Dear Mike Dunn,
> >
> >> On the xscale, the icache must be invalidated and the write buffers
> >> drained after writing code over the data bus, even if the caches are
> >> disabled. After rebasing with the main git repository, u-boot began
> >> crashing in odd places on my pxa270 board (palmtreo680) after the code
> >> relocation routine ran. This patch fixes it. Cache coherency problems
> >> are often
> >> hit-and-miss (ha ha), and this latent problem didn't rear its ugly head
> >> until now. Tested on the pxa270.
> >>
> >> Signed-off-by: Mike Dunn <mikedunn@newsguy.com>
> >> ---
> >>
> >> I realize that __ARM_ARCH_5TE__ does not necessarily mean xscale.
> >
> > We should introduce some CONFIG_PXA I guess.
>
> I think CONFIG_XSCALE is more correct, because if I'm not mistaken more
> recent Marvell processors continue to use the 'pxa' nomenclature in their
> name but do not contain xscale cores.
I suspect we might end up checking all the datasheets (PXA2xx, PXA3xx and
PXA9xx) to see which CPUs still need this fixup.
Best regards,
Marek Vasut
prev parent reply other threads:[~2013-06-20 20:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-17 18:07 [U-Boot] [PATCH] arm: fix memory coherency problem after relocation Mike Dunn
2013-06-20 13:56 ` Marek Vasut
2013-06-20 17:04 ` Mike Dunn
2013-06-20 20:19 ` Marek Vasut [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201306202219.20646.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.