From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olof Johansson Subject: Re: [PATCH] gpio: msm-v1: Remove errant __devinit to fix compile Date: Thu, 20 Jun 2013 18:48:28 -0700 Message-ID: <20130621014828.GA859@quad.lixom.net> References: <1370373600-31921-1-git-send-email-sboyd@codeaurora.org> <51BF43F4.9000007@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pa0-f41.google.com ([209.85.220.41]:64567 "EHLO mail-pa0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161221Ab3FUBsW (ORCPT ); Thu, 20 Jun 2013 21:48:22 -0400 Received: by mail-pa0-f41.google.com with SMTP id bj3so7056537pad.0 for ; Thu, 20 Jun 2013 18:48:21 -0700 (PDT) Content-Disposition: inline In-Reply-To: Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Linus Walleij Cc: Stephen Boyd , Grant Likely , "linux-kernel@vger.kernel.org" , "linux-arm-msm@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , David Brown On Tue, Jun 18, 2013 at 11:16:17AM +0200, Linus Walleij wrote: > On Mon, Jun 17, 2013 at 7:14 PM, Stephen Boyd wrote: > > On 06/16/13 22:54, Linus Walleij wrote: > >> On Tue, Jun 4, 2013 at 9:20 PM, Stephen Boyd wrote: > >> > >>> Commit 7bce696 (gpio: Make gpio-msm-v1 into a platform driver, > >>> 2013-03-04) was based on an older kernel where __devinit still > >>> existed. Remove the erroneous __devinit marking. > >>> > >>> Cc: David Brown > >>> Signed-off-by: Stephen Boyd > >> Patch applied. > > > > Thanks. It looks like David picked this up and sent it off to arm-soc > > last week. Cc'ing Olof for awareness of a possible duplicate. > > Did that get ack by some GPIO maintainer? > > This needs to go through the GPIO tree, but I > guess GIT will survive if it ends up in two trees. Nope, and it slipped through the cracks. More and more patches that we see lack proper acks, and it's becoming a problem. I have to go search for them on the lists and see if they came in without being tagged on the patch, etc. Time to get more strict on that, obviously. :( But yeah, one duplicate trivial patch like this shouldn't be an issue. -Olof From mboxrd@z Thu Jan 1 00:00:00 1970 From: olof@lixom.net (Olof Johansson) Date: Thu, 20 Jun 2013 18:48:28 -0700 Subject: [PATCH] gpio: msm-v1: Remove errant __devinit to fix compile In-Reply-To: References: <1370373600-31921-1-git-send-email-sboyd@codeaurora.org> <51BF43F4.9000007@codeaurora.org> Message-ID: <20130621014828.GA859@quad.lixom.net> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Jun 18, 2013 at 11:16:17AM +0200, Linus Walleij wrote: > On Mon, Jun 17, 2013 at 7:14 PM, Stephen Boyd wrote: > > On 06/16/13 22:54, Linus Walleij wrote: > >> On Tue, Jun 4, 2013 at 9:20 PM, Stephen Boyd wrote: > >> > >>> Commit 7bce696 (gpio: Make gpio-msm-v1 into a platform driver, > >>> 2013-03-04) was based on an older kernel where __devinit still > >>> existed. Remove the erroneous __devinit marking. > >>> > >>> Cc: David Brown > >>> Signed-off-by: Stephen Boyd > >> Patch applied. > > > > Thanks. It looks like David picked this up and sent it off to arm-soc > > last week. Cc'ing Olof for awareness of a possible duplicate. > > Did that get ack by some GPIO maintainer? > > This needs to go through the GPIO tree, but I > guess GIT will survive if it ends up in two trees. Nope, and it slipped through the cracks. More and more patches that we see lack proper acks, and it's becoming a problem. I have to go search for them on the lists and see if they came in without being tagged on the patch, etc. Time to get more strict on that, obviously. :( But yeah, one duplicate trivial patch like this shouldn't be an issue. -Olof