From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45883)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1Uq3cA-0003tz-OR
	for qemu-devel@nongnu.org; Fri, 21 Jun 2013 11:51:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1Uq3c9-0005IE-6I
	for qemu-devel@nongnu.org; Fri, 21 Jun 2013 11:51:06 -0400
Received: from mx1.redhat.com ([209.132.183.28]:45274)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1Uq3c8-0005I8-TI
	for qemu-devel@nongnu.org; Fri, 21 Jun 2013 11:51:05 -0400
Date: Fri, 21 Jun 2013 11:51:01 -0400
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20130621115101.1ffc557a@redhat.com>
In-Reply-To: <871u7vcvvs.fsf@codemonkey.ws>
References: <1371651055-1621-1-git-send-email-kwolf@redhat.com>
	<871u7vcvvs.fsf@codemonkey.ws>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] hmp: Make "info block" output more readable
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org

On Fri, 21 Jun 2013 10:43:19 -0500
Anthony Liguori <anthony@codemonkey.ws> wrote:

> Kevin Wolf <kwolf@redhat.com> writes:
> 
> > HMP is meant for humans and you should notice it.
> >
> > This changes the output format to use a bit more space to display the
> > information more readable and leaves out irrelevant information (e.g.
> > mention only that an image is encrypted, but not when it's not; display
> > I/O limits only if throttling is in effect; ...)
> >
> > Before:
> >
> >     (qemu) info block
> >     ide0-hd0: removable=0 io-status=ok file=/tmp/overlay.qcow2
> >     backing_file=/tmp/backing.img backing_file_depth=1 ro=0 drv=qcow2
> >     encrypted=1 bps=0 bps_rd=0 bps_wr=0 iops=1024 iops_rd=0 iops_wr=0
> >     ide1-cd0: removable=1 locked=0 tray-open=0 io-status=ok
> >     file=/home/kwolf/images/iso/Fedora-18-x86_64-Live-Desktop.iso ro=1
> >     drv=raw encrypted=0 bps=0 bps_rd=0 bps_wr=0 iops=0 iops_rd=0 iops_wr=0
> >     floppy0: removable=1 locked=0 tray-open=0 [not inserted]
> >     sd0: removable=1 locked=0 tray-open=0 [not inserted]
> >
> > After:
> >
> >     (qemu) info block
> >     ide0-hd0: /tmp/overlay.qcow2 (qcow2, encrypted)
> >         Backing file:     /tmp/backing.img (chain depth: 1)
> >         I/O limits:       bps=0 bps_rd=0 bps_wr=0 iops=1024 iops_rd=0 iops_wr=0
> >
> >     ide1-cd0: /home/kwolf/images/iso/Fedora-18-x86_64-Live-Desktop.iso (raw, read-only)
> >         Removable device: not locked, tray closed
> >
> >     floppy0: [not inserted]
> >         Removable device: not locked, tray closed
> >
> >     sd0: [not inserted]
> >         Removable device: not locked, tray closed
> 
> Acked-by: Anthony Liguori <aliguori@us.ibm.com>
> 
> I made a note on the changelog for 1.6 about this change.  Folks have
> had plenty of time to move to QMP so changing HMP output is reasonable
> at this point.

Yeah. I've already applied this one. I would consider not doing this
kind of change for HMP commands w/o QMP counterparts.