From mboxrd@z Thu Jan  1 00:00:00 1970
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: Re: [PATCH 2/3] V4 qemu-xen-trad: Correctly expose PCH
 ISA bridge for IGD passthrough
Date: Fri, 21 Jun 2013 14:01:44 -0400
Message-ID: <20130621180144.GB15809@phenom.dumpdata.com>
References: <CAKhsbWYydgFbO_Hk5OzViXjyWzq+DM0EeYpzDj3fzQVy0jw2vQ@mail.gmail.com>
	<51BF231C02000078000DED76@nat28.tlf.novell.com>
	<CAKhsbWbm+mWZCCeMFRmzQTO8RNnndTuKX2zEb3x=Qk7ytk+v3A@mail.gmail.com>
	<alpine.DEB.2.02.1306201431170.4548@kaball.uk.xensource.com>
	<CAKhsbWYvZwV76gnP0KTp1Re_qQzur9w-Ys16rDPHTj1P6SzTmw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Content-Disposition: inline
In-Reply-To: <CAKhsbWYvZwV76gnP0KTp1Re_qQzur9w-Ys16rDPHTj1P6SzTmw@mail.gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: "G.R." <firemeteor@users.sourceforge.net>
Cc: Ian Campbell <Ian.Campbell@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>, xen-devel <xen-devel@lists.xen.org>, Stefano Stabellini <stefano.stabellini@citrix.com>, Jan Beulich <JBeulich@suse.com>
List-Id: xen-devel@lists.xenproject.org

On Fri, Jun 21, 2013 at 09:25:49AM +0800, G.R. wrote:
> On Thu, Jun 20, 2013 at 9:31 PM, Stefano Stabellini
> <stefano.stabellini@eu.citrix.com> wrote:
> > On Mon, 17 Jun 2013, G.R. wrote:
> >> On Mon, Jun 17, 2013 at 8:54 PM, Jan Beulich <JBeulich@suse.com> wrote:
> >> >>>> On 17.06.13 at 14:42, "G.R." <firemeteor@users.sourceforge.net> wrote:
> >> >> The i915 driver probes chip version through PCH ISA bridge device / vendor
> >> >> ID.
> >> >> Previously, the PCH ISA bridge is exposed as PCI-PCI bridge in qemu-xen-trad,
> >> >> which breaks the assumption of the driver. This change fixes the issue by
> >> >> correctly exposing the ISA bridge to domU.
> >> >>
> >> >> Note the PIIX3 ISA bridge is still present on the bus (dropping it seems
> >> >> break qemu all-together), i915 driver still need to be updated to handle
> >> >> this.
> >> >>
> >> >> Change since last version:
> >> >>   1. Introduce helper function to avoid exposing PCI_Bus / PCI_Bridge
> >> >> definition to public.
> >> >>
> >> >> Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
> >> >>                Rui Guo <firemeteor@users.sourceforge.net>
> >> >> Tested-by: Rui Guo <firemeteor@users.sourceforge.net>
> >> >
> >> > I'm fine with this version, but does the above indeed reflect
> >> > reality? I.e. wasn't it you who wrote the patch in its current
> >> > form?
> >> >
> >>
> >> Ah! Thanks for pointing this out...
> >> I just keep carrying this sign-off lines from the original version.
> >> So I think I should use these lines for signing-off:
> >>  Signed-off-by: Rui Guo <firemeteor@users.sourceforge.net>
> >>  Tested-by: Rui Guo <firemeteor@users.sourceforge.net>
> >>
> >> Do I need to resend the whole thing out?
> >
> > I think it's OK and Ian should be able to change those lines for you
> >
> Thanks!
> PS: I finally have i915 driver maintainer accepted my patch about the
> pch detection.

Nice. Which one was it? Do you have a URL for it?

Thanks!
> So together with this patch, it would produce a working ouf-of-box linux set.
> > _______________________________________________
> > Xen-devel mailing list
> > Xen-devel@lists.xen.org
> > http://lists.xen.org/xen-devel
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
>