From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1946215Ab3FUWJ3 (ORCPT ); Fri, 21 Jun 2013 18:09:29 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:35081 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1946172Ab3FUWJ1 (ORCPT ); Fri, 21 Jun 2013 18:09:27 -0400 Date: Fri, 21 Jun 2013 15:10:05 -0700 From: Greg Kroah-Hartman To: Sergey Senozhatsky Cc: Nitin Gupta , Minchan Kim , linux-kernel@vger.kernel.org Subject: Re: [PATCH staging-next] zram: remove zram_sysfs file Message-ID: <20130621221005.GA1842@kroah.com> References: <20130621152914.GA2371@swordfish.minsk.epam.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130621152914.GA2371@swordfish.minsk.epam.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 21, 2013 at 06:29:14PM +0300, Sergey Senozhatsky wrote: > Move zram sysfs code to zram drv and remove zram_sysfs file. > This gives ability to make static a number of previously exported > zram functions, used from zram sysfs, e.g. internal zram > zram_meta_alloc/free(). We also can drop several zram_drv wrapper > functions, used from zram sysfs: > e.g. zram_reset_device()/__zram_reset_device() pair. > > Signed-off-by: Sergey Senozhatsky > > --- > drivers/staging/zram/Makefile | 2 +- > drivers/staging/zram/zram_drv.c | 524 +++++++++++++++++++++++++------------- > drivers/staging/zram/zram_drv.h | 10 - > drivers/staging/zram/zram_sysfs.c | 209 --------------- > 4 files changed, 354 insertions(+), 391 deletions(-) > > diff --git a/drivers/staging/zram/Makefile b/drivers/staging/zram/Makefile > index 7f4a301..cb0f9ce 100644 > --- a/drivers/staging/zram/Makefile > +++ b/drivers/staging/zram/Makefile > @@ -1,3 +1,3 @@ > -zram-y := zram_drv.o zram_sysfs.o > +zram-y := zram_drv.o > > obj-$(CONFIG_ZRAM) += zram.o > diff --git a/drivers/staging/zram/zram_drv.c b/drivers/staging/zram/zram_drv.c > index ec2b2b5..f32fcca 100644 > --- a/drivers/staging/zram/zram_drv.c > +++ b/drivers/staging/zram/zram_drv.c > @@ -42,6 +42,111 @@ static struct zram *zram_devices; > /* Module params (documentation at end) */ > static unsigned int num_devices = 1; > > +module_param(num_devices, uint, 0); > +MODULE_PARM_DESC(num_devices, "Number of zram devices"); > + > +MODULE_LICENSE("Dual BSD/GPL"); > +MODULE_AUTHOR("Nitin Gupta "); > +MODULE_DESCRIPTION("Compressed RAM Block Device"); This is usually best put at the bottom of the file, not at the top. Why did you move it? thanks, greg k-h