From: Theodore Ts'o <tytso@mit.edu>
To: Jan Kara <jack@suse.cz>
Cc: Ext4 Developers List <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH 1/2] ext4: remove while loop in mpage_map_and_submit_extent()
Date: Fri, 21 Jun 2013 23:48:32 -0400 [thread overview]
Message-ID: <20130622034832.GA4727@thunk.org> (raw)
In-Reply-To: <20130621163236.GN13932@quack.suse.cz>
On Fri, Jun 21, 2013 at 06:32:36PM +0200, Jan Kara wrote:
> This is not true. In case blocksize < pagesize and we were not able to
> map a full page, mpage_map_and_submit_buffers() changes mpd->map to point
> to the next extent inside the page that needs mapping. In that case we can
> take several iterations of the loop. Maybe this fact deserves a comment
> before the loop but there's a comment before the callsite of
> mpage_map_and_submit_buffers() which mentions that it will get us next
> extent to map and also the documentation of mpage_map_and_submit_buffers()
> explicitely tells that it can update mpd->map.
Ah, right. Thanks, I missed where that was happening the first time I
was analyzing that function.
I've dropped this patch.
- Ted
prev parent reply other threads:[~2013-06-22 3:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-17 13:58 [PATCH 1/2] ext4: remove while loop in mpage_map_and_submit_extent() Theodore Ts'o
2013-06-17 13:58 ` [PATCH 2/2] ext4: fix up error handling for mpage_map_and_submit_extent() Theodore Ts'o
2013-06-21 16:38 ` Jan Kara
2013-06-22 3:50 ` [PATCH -v2] " Theodore Ts'o
2013-06-21 16:32 ` [PATCH 1/2] ext4: remove while loop in mpage_map_and_submit_extent() Jan Kara
2013-06-22 3:48 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130622034832.GA4727@thunk.org \
--to=tytso@mit.edu \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.