All of lore.kernel.org
 help / color / mirror / Atom feed
From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] board/bsc913x: Add config flag for bootdelay
Date: Sun, 23 Jun 2013 09:07:14 +0200	[thread overview]
Message-ID: <20130623090714.55a767c1@lilith> (raw)
In-Reply-To: <1371469712-12678-1-git-send-email-harninder.rai@freescale.com>

Hi Harninder,

On Mon, 17 Jun 2013 17:18:32 +0530, Harninder Rai
<harninder.rai@freescale.com> wrote:

> Keep the value of CONFIG_BOOTDELAY as -1 to disable autoboot
> 
> Signed-off-by: Harninder Rai <harninder.rai@freescale.com>
> ---
>  include/configs/BSC9131RDB.h |    1 +
>  include/configs/BSC9132QDS.h |    1 +
>  2 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/include/configs/BSC9131RDB.h b/include/configs/BSC9131RDB.h
> index fd076e0..c56b119 100644
> --- a/include/configs/BSC9131RDB.h
> +++ b/include/configs/BSC9131RDB.h
> @@ -393,6 +393,7 @@ extern unsigned long get_sdram_size(void);
>  #define CONFIG_UBOOTPATH	"u-boot.bin" /* U-Boot image on TFTP server */
>  
>  #define CONFIG_BAUDRATE		115200
> +#define CONFIG_BOOTDELAY	-1 /* Disable autoboot */
>  
>  #define	CONFIG_EXTRA_ENV_SETTINGS				\
>  	"netdev=eth0\0"						\
> diff --git a/include/configs/BSC9132QDS.h b/include/configs/BSC9132QDS.h
> index 9d15d0e..d54900a 100644
> --- a/include/configs/BSC9132QDS.h
> +++ b/include/configs/BSC9132QDS.h
> @@ -607,6 +607,7 @@ combinations. this should be removed later
>  #define CONFIG_UBOOTPATH	"u-boot.bin"
>  
>  #define CONFIG_BAUDRATE		115200
> +#define CONFIG_BOOTDELAY	-1 /* Disable autoboot */
>  
>  #ifdef CONFIG_SDCARD
>  #define CONFIG_DEF_HWCONFIG	"hwconfig=usb1:dr_mode=host,phy_type=ulpi\0"

Plase fix commit message: you're not simply adding a boot delay flag,
you're in fact disabling autoboot, which is quite different.

Also, when touching on a board's code, you should Cc: the board's
maintainer(s). Please do so for V2 of your patch -- and if you get a
non-delivery status (e.g. a maintainer's mail address does not exist any
more), please follow up on your patch submission to let us know.

Amicalement,
-- 
Albert.

  reply	other threads:[~2013-06-23  7:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-17 11:48 [U-Boot] [PATCH] board/bsc913x: Add config flag for bootdelay Harninder Rai
2013-06-23  7:07 ` Albert ARIBAUD [this message]
2013-06-24  9:28   ` Rai Harninder-B01044
2013-06-24 17:11     ` Albert ARIBAUD
2013-06-25 12:38       ` Rai Harninder-B01044
2013-06-25 17:45         ` Scott Wood
2013-06-25  0:01     ` Scott Wood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130623090714.55a767c1@lilith \
    --to=albert.u.boot@aribaud.net \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.