From: John Keeping <john@keeping.me.uk>
To: Dave Abrahams <dave@boostpro.com>
Cc: git@vger.kernel.org, Jonathan Nieder <jrnieder@gmail.com>
Subject: Re: fast-import bug?
Date: Sun, 23 Jun 2013 15:55:03 +0100 [thread overview]
Message-ID: <20130623145503.GH4676@serenity.lan> (raw)
In-Reply-To: <m2ppvc29le.fsf@cube.gateway.2wire.net>
On Sun, Jun 23, 2013 at 07:19:25AM -0700, Dave Abrahams wrote:
> on Sun Jun 23 2013, John Keeping <john-AT-keeping.me.uk> wrote:
> > In this case, I think I do now understand why the mode is 0: in
> > parse_ls a new tree object is created and the SHA1 of the original is
> > copied in but the mode is left blank; clearly this should be set to
> > S_IFDIR when the SHA1 is non-null.
> >
> > I think the patch I now have is correct (and addresses the "copy from
> > root" scenario), but I need to spend some time understanding t9300 so
> > that I can add suitable test cases.
>
> t9300?
t/t9300-fast-import.sh in Git's source tree - it's where the tests for
fast-import live.
> Thanks; I'll try this one too.
Thanks. I now have a patch series incorporating this which also adds a
few tests for handling of empty paths. I'm sending it out in the next
few minutes.
prev parent reply other threads:[~2013-06-23 14:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-21 9:21 fast-import bug? Dave Abrahams
2013-06-22 10:21 ` John Keeping
2013-06-23 2:16 ` Dave Abrahams
2013-06-23 11:09 ` John Keeping
2013-06-23 14:19 ` Dave Abrahams
2013-06-23 14:55 ` John Keeping [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130623145503.GH4676@serenity.lan \
--to=john@keeping.me.uk \
--cc=dave@boostpro.com \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.