From mboxrd@z Thu Jan  1 00:00:00 1970
From: Gleb Natapov <gleb@redhat.com>
Subject: Re: [PATCH kvm-unit-tests 1/3] x86-run: correct a typo 'qemsystem'
 -> 'qemusystem'
Date: Mon, 24 Jun 2013 11:03:13 +0300
Message-ID: <20130624080313.GA18508@redhat.com>
References: <1B4B44D9196EFF41AE41FDA404FC0A1001B1DAB6@SHSMSX102.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"pbonzini@redhat.com" <pbonzini@redhat.com>
To: "Ren, Yongjie" <yongjie.ren@intel.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:4435 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752647Ab3FXIDQ (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 24 Jun 2013 04:03:16 -0400
Content-Disposition: inline
In-Reply-To: <1B4B44D9196EFF41AE41FDA404FC0A1001B1DAB6@SHSMSX102.ccr.corp.intel.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Mon, Jun 24, 2013 at 06:10:59AM +0000, Ren, Yongjie wrote:
> x86-run: correct a typo 'qemsystem' -> 'qemusystem'
> Before this fix, you should always get error info as below when running 'x86-run' script.
> "QEMU binary has no support for test device. Exiting."
> 
Patch is whitespace damaged.

> Signed-off-by: Yongjie Ren <yongjie.ren@intel.com>
> ---
>  x86-run |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/x86-run b/x86-run
> index 2cf1f38..9526a0b 100755
> --- a/x86-run
> +++ b/x86-run
> @@ -8,7 +8,7 @@ then
>         qemu="${qemukvm}"
>  else
>         if
> -               ${qemsystem} -device '?' 2>&1 | fgrep -e \"testdev\" -e \"pc-testdev\" > /dev/null;
> +               ${qemusystem} -device '?' 2>&1 | fgrep -e \"testdev\" -e \"pc-testdev\" > /dev/null;
While you are at is lets replace fgrep invocation, which is deprecated,
with grep -F.

>         then
>                 qemu="${qemusystem}"
>         else
> --
> 1.7.9.5

--
			Gleb.