Re: [LTP] [PATCH] tst_module: create new library functions for kernel modules

[Mike Frysinger <vapier@gentoo.org>]

[-- Attachment #1.1: Type: Text/Plain, Size: 640 bytes --]

On Monday 24 June 2013 06:01:39 alexey.kodanev@oracle.com wrote:
> On 06/22/2013 10:15 PM, Mike Frysinger wrote:
> >> +/* declared in tst_tmpdir.c */
> >> +const char *tst_get_startwd(void);
> > 
> > use a proper header instead.  extern func decls only leads to bit rot and
> > hard to debug crashes.
> 
> But, there is no header for this function in LTP, it is declared inside
> c file, and I
> used it in the same way as it was already used in tst_resource.c.

... so add the decl to an existing header and fix the existing usage.  the fact 
that someone else did it wrong doesn't justify extending that misbehavior.
-mike

[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 184 bytes --]

------------------------------------------------------------------------------
This SF.net email is sponsored by Windows:

Build for Windows Store.

http://p.sf.net/sfu/windows-dev2dev

[-- Attachment #3: Type: text/plain, Size: 155 bytes --]

_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list