From: Zheng Liu <gnehzuil.liu@gmail.com>
To: "Sidorov, Andrei" <Andrei.Sidorov@arrisi.com>
Cc: Namjae Jeon <linkinjeon@gmail.com>,
Christoph Hellwig <hch@infradead.org>,
Dave Chinner <david@fromorbit.com>,
Eric Sandeen <esandeen@redhat.com>,
Andreas Dilger <adilger@dilger.ca>,
"tytso@mit.edu" <tytso@mit.edu>,
"adilger.kernel@dilger.ca" <adilger.kernel@dilger.ca>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>,
"a.sangwan@samsung.com" <a.sangwan@samsung.com>,
Namjae Jeon <namjae.jeon@samsung.com>
Subject: Re: [PATCH 0/3] ext4: introduce two new ioctls
Date: Mon, 24 Jun 2013 22:14:39 +0800 [thread overview]
Message-ID: <20130624141439.GA8275@gmail.com> (raw)
In-Reply-To: <C0F0BC787567C848B2C90989451123DA2363CDB7@ATLEXMBX4.ARRS.ARRISI.com>
On Mon, Jun 24, 2013 at 10:37:57AM +0000, Sidorov, Andrei wrote:
> On 24.06.2013 13:36, Namjae Jeon wrote:
> > Currently, we can try implementing dave's suggesstion of introducing a
> > new flag FALLOC_FL_COLLAPSE_RANGE for falloctae instead of individual
> > ioctls for both XFS and EXT4. Thanks.
>
> Hi,
>
> Currently PUNCH_HOLE requires KEEP_SIZE to be set as well. I think there
> is no need to invent COLLAPSE_RANGE, but instead fallocate should
> support PUNCH_HOLE without KEEP_SIZE. However I'm not sure that putting
> block alignment restriction is a right way to go.
PUNCH_HOLE without KEEP_SIZE makes sense to me.
Regards,
- Zheng
next prev parent reply other threads:[~2013-06-24 14:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-23 6:07 [PATCH 0/3] ext4: introduce two new ioctls Namjae Jeon
2013-06-23 6:22 ` Namjae Jeon
2013-06-23 17:00 ` Andreas Dilger
2013-06-24 0:32 ` Eric Sandeen
2013-06-24 2:44 ` Dave Chinner
2013-06-24 3:12 ` Theodore Ts'o
2013-06-24 8:08 ` Dave Chinner
2013-06-24 7:06 ` Christoph Hellwig
2013-06-24 9:35 ` Namjae Jeon
2013-06-24 10:37 ` Sidorov, Andrei
2013-06-24 14:14 ` Zheng Liu [this message]
2013-06-24 21:29 ` Dave Chinner
2013-06-24 6:48 ` Namjae Jeon
-- strict thread matches above, loose matches on Subject: below --
2013-06-23 6:05 Namjae Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130624141439.GA8275@gmail.com \
--to=gnehzuil.liu@gmail.com \
--cc=Andrei.Sidorov@arrisi.com \
--cc=a.sangwan@samsung.com \
--cc=adilger.kernel@dilger.ca \
--cc=adilger@dilger.ca \
--cc=david@fromorbit.com \
--cc=esandeen@redhat.com \
--cc=hch@infradead.org \
--cc=linkinjeon@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=namjae.jeon@samsung.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.