All of lore.kernel.org
 help / color / mirror / Atom feed
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] pinctrl: document the pinctrl PM states
Date: Tue, 25 Jun 2013 00:31:35 -0700	[thread overview]
Message-ID: <20130625073134.GE5523@atomide.com> (raw)
In-Reply-To: <CACRpkdY7hF+9s0f64yc09DHLFQCjzzhPoS-ypBmgit=kFFD0Mg@mail.gmail.com>

* Linus Walleij <linus.walleij@linaro.org> [130624 05:43]:
> On Mon, Jun 17, 2013 at 8:02 PM, Tony Lindgren <tony@atomide.com> wrote:
> > * Linus Walleij <linus.walleij@linaro.org> [130617 09:11]:
> 
> >> Bear in mind that struct pinctl * forks effects in two paths,
> >> one is muxing the other is config, like pull-ups etc.
> >
> > I also thought the plan was to merge pinmux and pinconf and
> > do things based the named modes?
> 
> That is done from a consumer point of view.
> Consumers only care about pinctrl * handles
> and pinctrl_state * switches.
> 
> > The last time I tried using the pinconf functions it involved
> > knowing the name of the pin in the consumer driver. The name
> > may not be very descriptive in the device tree cases at least
> > for the pinctrl-single. So I did not pay much attention to
> > the pinconf functions.
> 
> Consumers should not use that interface, i.e.:
> 
> int pin_config_get(const char *dev_name, const char *name,
>                                 unsigned long *config);
> int pin_config_set(const char *dev_name, const char *name,
>                                  unsigned long config)
> 
> This needs to be deleted from <linux/pinctrl/consumer.h>
> I'll see if I can get rid of it pronto to avoid any more confusion
> and sorry for leaving that in place for too long.
> 
> The proper way to use it is to use the states.

OK thanks for clarifying that. Yes I think the named states
is a good way to handle the pins in a generic way.

Regards,

Tony

WARNING: multiple messages have this Message-ID (diff)
From: Tony Lindgren <tony@atomide.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Stephen Warren <swarren@wwwdotorg.org>,
	Linus Walleij <linus.walleij@stericsson.com>,
	Stephen Warren <swarren@nvidia.com>,
	Kevin Hilman <khilman@linaro.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	Ulf Hansson <ulf.hansson@linaro.org>
Subject: Re: [PATCH] pinctrl: document the pinctrl PM states
Date: Tue, 25 Jun 2013 00:31:35 -0700	[thread overview]
Message-ID: <20130625073134.GE5523@atomide.com> (raw)
In-Reply-To: <CACRpkdY7hF+9s0f64yc09DHLFQCjzzhPoS-ypBmgit=kFFD0Mg@mail.gmail.com>

* Linus Walleij <linus.walleij@linaro.org> [130624 05:43]:
> On Mon, Jun 17, 2013 at 8:02 PM, Tony Lindgren <tony@atomide.com> wrote:
> > * Linus Walleij <linus.walleij@linaro.org> [130617 09:11]:
> 
> >> Bear in mind that struct pinctl * forks effects in two paths,
> >> one is muxing the other is config, like pull-ups etc.
> >
> > I also thought the plan was to merge pinmux and pinconf and
> > do things based the named modes?
> 
> That is done from a consumer point of view.
> Consumers only care about pinctrl * handles
> and pinctrl_state * switches.
> 
> > The last time I tried using the pinconf functions it involved
> > knowing the name of the pin in the consumer driver. The name
> > may not be very descriptive in the device tree cases at least
> > for the pinctrl-single. So I did not pay much attention to
> > the pinconf functions.
> 
> Consumers should not use that interface, i.e.:
> 
> int pin_config_get(const char *dev_name, const char *name,
>                                 unsigned long *config);
> int pin_config_set(const char *dev_name, const char *name,
>                                  unsigned long config)
> 
> This needs to be deleted from <linux/pinctrl/consumer.h>
> I'll see if I can get rid of it pronto to avoid any more confusion
> and sorry for leaving that in place for too long.
> 
> The proper way to use it is to use the states.

OK thanks for clarifying that. Yes I think the named states
is a good way to handle the pins in a generic way.

Regards,

Tony


  reply	other threads:[~2013-06-25  7:31 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-11 19:59 [PATCH] pinctrl: document the pinctrl PM states Linus Walleij
2013-06-11 19:59 ` Linus Walleij
2013-06-12 18:37 ` Tony Lindgren
2013-06-12 18:37   ` Tony Lindgren
2013-06-13 19:39 ` Stephen Warren
2013-06-13 19:39   ` Stephen Warren
2013-06-13 20:34   ` Linus Walleij
2013-06-13 20:34     ` Linus Walleij
2013-06-14 15:43     ` Stephen Warren
2013-06-14 15:43       ` Stephen Warren
2013-06-16 10:17       ` Linus Walleij
2013-06-16 10:17         ` Linus Walleij
2013-06-17  7:20       ` Tony Lindgren
2013-06-17  7:20         ` Tony Lindgren
2013-06-17 15:56         ` Linus Walleij
2013-06-17 15:56           ` Linus Walleij
2013-06-17 18:06           ` Tony Lindgren
2013-06-17 18:06             ` Tony Lindgren
2013-06-17 18:15           ` Rohit Vaswani
2013-06-17 18:15             ` Rohit Vaswani
2013-06-17 16:05         ` Linus Walleij
2013-06-17 16:05           ` Linus Walleij
2013-06-17 18:02           ` Tony Lindgren
2013-06-17 18:02             ` Tony Lindgren
2013-06-19 20:06             ` Stephen Warren
2013-06-19 20:06               ` Stephen Warren
2013-06-24 12:37             ` Linus Walleij
2013-06-24 12:37               ` Linus Walleij
2013-06-25  7:31               ` Tony Lindgren [this message]
2013-06-25  7:31                 ` Tony Lindgren
2013-06-19 20:02         ` Stephen Warren
2013-06-19 20:02           ` Stephen Warren
2013-06-20  6:38           ` Tony Lindgren
2013-06-20  6:38             ` Tony Lindgren
2013-06-20 19:26             ` Stephen Warren
2013-06-20 19:26               ` Stephen Warren
2013-06-21  6:25               ` Tony Lindgren
2013-06-21  6:25                 ` Tony Lindgren
2013-06-21 19:12                 ` Stephen Warren
2013-06-21 19:12                   ` Stephen Warren
2013-06-24 10:10                   ` Tony Lindgren
2013-06-24 10:10                     ` Tony Lindgren
2013-06-24 18:09                     ` Stephen Warren
2013-06-24 18:09                       ` Stephen Warren
2013-06-25  7:38                       ` Tony Lindgren
2013-06-25  7:38                         ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130625073134.GE5523@atomide.com \
    --to=tony@atomide.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.