From mboxrd@z Thu Jan 1 00:00:00 1970 From: Martin Schwidefsky Subject: Re: [Suggestion] arch: s390: mm: the warnings with allmodconfig and "EXTRA_CFLAGS=-W" Date: Tue, 25 Jun 2013 08:50:06 +0200 Message-ID: <20130625085006.01a7f368@mschwide> References: <51C8F685.6000209@asianux.com> <51C8F861.9010101@asianux.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <51C8F861.9010101@asianux.com> Sender: owner-linux-mm@kvack.org To: Chen Gang Cc: Heiko Carstens , linux390@de.ibm.com, cornelia.huck@de.ibm.com, mtosatti@redhat.com, Thomas Gleixner , linux-s390@vger.kernel.org, "linux-kernel@vger.kernel.org" , Linux-Arch , linux-mm@kvack.org List-Id: linux-arch.vger.kernel.org On Tue, 25 Jun 2013 09:54:41 +0800 Chen Gang wrote: > Hello Maintainers: >=20 > When allmodconfig for " IBM zSeries model z800 and z900" >=20 > It will report the related warnings ("EXTRA_CFLAGS=3D-W"): > mm/slub.c:1875:1: warning: =E2=80=98deactivate_slab=E2=80=99 uses dynam= ic stack allocation [enabled by default] > mm/slub.c:1941:1: warning: =E2=80=98unfreeze_partials.isra.32=E2=80=99 = uses dynamic stack allocation [enabled by default] > mm/slub.c:2575:1: warning: =E2=80=98__slab_free=E2=80=99 uses dynamic s= tack allocation [enabled by default] > mm/slub.c:1582:1: warning: =E2=80=98get_partial_node.isra.34=E2=80=99 u= ses dynamic stack allocation [enabled by default] > mm/slub.c:2311:1: warning: =E2=80=98__slab_alloc.constprop.42=E2=80=99 = uses dynamic stack allocation [enabled by default] >=20 > Is it OK ? Yes, these warnings should be ok. They are enabled by CONFIG_WARN_DYNAMIC_S= TACK, the purpose is to find all functions with dynamic stack allocations. The ch= eck if the allocations are truly ok needs to be done manually as the compiler can not find out the maximum allocation size automatically. --=20 blue skies, Martin. "Reality continues to ruin my life." - Calvin. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from e06smtp14.uk.ibm.com ([195.75.94.110]:42650 "EHLO e06smtp14.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751592Ab3FYGuP convert rfc822-to-8bit (ORCPT ); Tue, 25 Jun 2013 02:50:15 -0400 Received: from /spool/local by e06smtp14.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 25 Jun 2013 07:42:49 +0100 Date: Tue, 25 Jun 2013 08:50:06 +0200 From: Martin Schwidefsky Subject: Re: [Suggestion] arch: s390: mm: the warnings with allmodconfig and "EXTRA_CFLAGS=-W" Message-ID: <20130625085006.01a7f368@mschwide> In-Reply-To: <51C8F861.9010101@asianux.com> References: <51C8F685.6000209@asianux.com> <51C8F861.9010101@asianux.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-arch-owner@vger.kernel.org List-ID: To: Chen Gang Cc: Heiko Carstens , linux390@de.ibm.com, cornelia.huck@de.ibm.com, mtosatti@redhat.com, Thomas Gleixner , linux-s390@vger.kernel.org, "linux-kernel@vger.kernel.org" , Linux-Arch , linux-mm@kvack.org Message-ID: <20130625065006.9nVf-cqdfTs0BrmaOdm4f8CQDGItep_9cSWKJDxCLyk@z> On Tue, 25 Jun 2013 09:54:41 +0800 Chen Gang wrote: > Hello Maintainers: > > When allmodconfig for " IBM zSeries model z800 and z900" > > It will report the related warnings ("EXTRA_CFLAGS=-W"): > mm/slub.c:1875:1: warning: ‘deactivate_slab’ uses dynamic stack allocation [enabled by default] > mm/slub.c:1941:1: warning: ‘unfreeze_partials.isra.32’ uses dynamic stack allocation [enabled by default] > mm/slub.c:2575:1: warning: ‘__slab_free’ uses dynamic stack allocation [enabled by default] > mm/slub.c:1582:1: warning: ‘get_partial_node.isra.34’ uses dynamic stack allocation [enabled by default] > mm/slub.c:2311:1: warning: ‘__slab_alloc.constprop.42’ uses dynamic stack allocation [enabled by default] > > Is it OK ? Yes, these warnings should be ok. They are enabled by CONFIG_WARN_DYNAMIC_STACK, the purpose is to find all functions with dynamic stack allocations. The check if the allocations are truly ok needs to be done manually as the compiler can not find out the maximum allocation size automatically. -- blue skies, Martin. "Reality continues to ruin my life." - Calvin.