From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH 2/3] V4 qemu-xen-trad: Correctly expose PCH ISA bridge for IGD passthrough Date: Tue, 25 Jun 2013 10:40:45 -0400 Message-ID: <20130625144045.GL28113@phenom.dumpdata.com> References: <51BF231C02000078000DED76@nat28.tlf.novell.com> <20130621180144.GB15809@phenom.dumpdata.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: "G.R." Cc: Ian Campbell , Stefano Stabellini , Ian Jackson , xen-devel , Stefano Stabellini , Jan Beulich List-Id: xen-devel@lists.xenproject.org On Tue, Jun 25, 2013 at 09:14:25PM +0800, G.R. wrote: > On Sat, Jun 22, 2013 at 2:01 AM, Konrad Rzeszutek Wilk > wrote: > > On Fri, Jun 21, 2013 at 09:25:49AM +0800, G.R. wrote: > >> On Thu, Jun 20, 2013 at 9:31 PM, Stefano Stabellini > >> wrote: > >> > On Mon, 17 Jun 2013, G.R. wrote: > >> >> On Mon, Jun 17, 2013 at 8:54 PM, Jan Beulich wrote: > >> >> >>>> On 17.06.13 at 14:42, "G.R." wrote: > >> >> >> The i915 driver probes chip version through PCH ISA bridge device / vendor > >> >> >> ID. > >> >> >> Previously, the PCH ISA bridge is exposed as PCI-PCI bridge in qemu-xen-trad, > >> >> >> which breaks the assumption of the driver. This change fixes the issue by > >> >> >> correctly exposing the ISA bridge to domU. > >> >> >> > >> >> >> Note the PIIX3 ISA bridge is still present on the bus (dropping it seems > >> >> >> break qemu all-together), i915 driver still need to be updated to handle > >> >> >> this. > >> >> >> > >> >> >> Change since last version: > >> >> >> 1. Introduce helper function to avoid exposing PCI_Bus / PCI_Bridge > >> >> >> definition to public. > >> >> >> > >> >> >> Signed-off-by: Stefano Stabellini , > >> >> >> Rui Guo > >> >> >> Tested-by: Rui Guo > >> >> > > >> >> > I'm fine with this version, but does the above indeed reflect > >> >> > reality? I.e. wasn't it you who wrote the patch in its current > >> >> > form? > >> >> > > >> >> > >> >> Ah! Thanks for pointing this out... > >> >> I just keep carrying this sign-off lines from the original version. > >> >> So I think I should use these lines for signing-off: > >> >> Signed-off-by: Rui Guo > >> >> Tested-by: Rui Guo > >> >> > >> >> Do I need to resend the whole thing out? > >> > > >> > I think it's OK and Ian should be able to change those lines for you > >> > > >> Thanks! > >> PS: I finally have i915 driver maintainer accepted my patch about the > >> pch detection. > > > > Nice. Which one was it? Do you have a URL for it? > > > This is the ack I got from the maintainer. > http://lists.freedesktop.org/archives/intel-gfx/2013-June/029171.html > > Note that the i915 patch has to work together with this patch. It > won't work by itself. Excellent. Good job!