All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Heiko Stübner" <heiko@sntech.de>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Stephen Warren <swarren@wwwdotorg.org>,
	James Hogan <james.hogan@imgtec.com>,
	linux-kernel@vger.kernel.org,
	devicetree-discuss@lists.ozlabs.org,
	Grant Likely <grant.likely@linaro.org>,
	Rob Herring <rob.herring@calxeda.com>
Subject: [PATCH 1/4] pinctrl: more clarifications for generic pull configs
Date: Tue, 25 Jun 2013 14:55:42 +0200	[thread overview]
Message-ID: <201306251455.42495.heiko@sntech.de> (raw)
In-Reply-To: <201306251455.01540.heiko@sntech.de>

PULL_PIN_DEFAULT is meant for hardware completely hiding any pull
settings from the driver, so that it's really only possible to turn
the pull on or off, but it not being possible to determine any
pull settings from software.

Also the binding-documentation for the pull arguments did not match
the changes to the expected values.

Signed-off-by: Heiko Stuebner <heiko@sntech.de>
---
 Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt |    5 ++---
 include/linux/pinctrl/pinconf-generic.h                        |    5 ++++-
 2 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt b/Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt
index 2d730e3..7498bdc 100644
--- a/Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt
+++ b/Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt
@@ -165,9 +165,8 @@ output-high		- set the pin to output mode with high level
 
 Arguments for parameters:
 
-- bias-pull-up, -down and -pin-default take as optional argument 0 to disable
-  the pull, on hardware supporting it the pull strength in Ohm. bias-disable
-  will also disable any active pull.
+- bias-pull-up, -down and -pin-default take as optional argument on hardware
+  supporting it the pull strength in Ohm. bias-disable will disable the pull.
 
 - drive-strength takes as argument the target strength in mA.
 
diff --git a/include/linux/pinctrl/pinconf-generic.h b/include/linux/pinctrl/pinconf-generic.h
index 10ad996..48aa4ba 100644
--- a/include/linux/pinctrl/pinconf-generic.h
+++ b/include/linux/pinctrl/pinconf-generic.h
@@ -41,7 +41,10 @@
  *	impedance to GROUND). If the argument is != 0 pull-down is enabled,
  *	if it is 0, pull-down is total, i.e. the pin is connected to GROUND.
  * @PIN_CONFIG_BIAS_PULL_PIN_DEFAULT: the pin will be pulled up or down based
- *	on embedded knowledge of the controller, like current mux function.
+ *	on embedded knowledge of the controller hardware, like current mux
+ *	function. The pull direction and possibly strength too will normally
+ *	be decided completely inside the hardware block and not be readable
+ *	from the kernel side.
  *	If the argument is != 0 pull up/down is enabled, if it is 0, the
  *	configuration is ignored. The proper way to disable it is to use
  *	@PIN_CONFIG_BIAS_DISABLE.
-- 
1.7.10.4

  reply	other threads:[~2013-06-25 12:55 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-25 12:55 [PATCH 0/4] Fix more issues with generic pinconf bindings Heiko Stübner
2013-06-25 12:55 ` Heiko Stübner
2013-06-25 12:55 ` Heiko Stübner [this message]
2013-06-25 13:14   ` [PATCH 1/4] pinctrl: more clarifications for generic pull configs Linus Walleij
2013-06-25 12:56 ` [PATCH 2/4] pinctrl: set unit for debounce time pinconfig to usec Heiko Stübner
2013-06-25 13:15   ` Linus Walleij
     [not found] ` <201306251455.01540.heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
2013-06-25 12:56   ` [PATCH 3/4] pinctrl: remove slew-rate parameter from tz1090 Heiko Stübner
2013-06-25 12:56     ` Heiko Stübner
2013-06-25 13:05     ` James Hogan
2013-06-25 13:05       ` James Hogan
2013-06-25 13:21       ` Heiko Stübner
2013-06-25 13:27         ` James Hogan
2013-06-25 13:27           ` James Hogan
2013-06-25 13:32           ` Linus Walleij
2013-06-25 13:50             ` James Hogan
2013-06-25 15:39               ` Linus Walleij
2013-06-25 21:40                 ` Stephen Warren
2013-06-25 13:22       ` Linus Walleij
2013-06-25 14:57         ` James Hogan
2013-06-25 21:46           ` Stephen Warren
2013-06-27  8:32             ` Linus Walleij
2013-06-25 12:57 ` [PATCH 4/4] pinctrl: remove bindings for pinconf options needing more thought Heiko Stübner
2013-06-25 13:34   ` Linus Walleij
2013-06-25 13:16 ` [PATCH 0/4] Fix more issues with generic pinconf bindings James Hogan
2013-06-25 13:16   ` James Hogan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201306251455.42495.heiko@sntech.de \
    --to=heiko@sntech.de \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=grant.likely@linaro.org \
    --cc=james.hogan@imgtec.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rob.herring@calxeda.com \
    --cc=swarren@wwwdotorg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.