From: "Heiko Stübner" <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
To: Linus Walleij <linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: James Hogan <james.hogan-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org>,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>,
Grant Likely
<grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Subject: [PATCH 3/4] pinctrl: remove slew-rate parameter from tz1090
Date: Tue, 25 Jun 2013 14:56:36 +0200 [thread overview]
Message-ID: <201306251456.36499.heiko@sntech.de> (raw)
In-Reply-To: <201306251455.01540.heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
As the binding for slew-rate is under discussion and seems to need
more tought it will get removed for now, so it doesn't get an offical
release.
Therefore remove it again from the only current user, tz1090.
Signed-off-by: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
---
.../devicetree/bindings/pinctrl/img,tz1090-pdc-pinctrl.txt | 5 +----
.../devicetree/bindings/pinctrl/img,tz1090-pinctrl.txt | 7 +------
drivers/pinctrl/pinctrl-tz1090-pdc.c | 5 -----
drivers/pinctrl/pinctrl-tz1090.c | 5 -----
4 files changed, 2 insertions(+), 20 deletions(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/img,tz1090-pdc-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/img,tz1090-pdc-
pinctrl.txt
index 9f7a85b..a186181 100644
--- a/Documentation/devicetree/bindings/pinctrl/img,tz1090-pdc-pinctrl.txt
+++ b/Documentation/devicetree/bindings/pinctrl/img,tz1090-pdc-pinctrl.txt
@@ -44,9 +44,6 @@ Optional subnode-properties:
- bias-pull-down
- input-schmitt-enable
- input-schmitt-disable
- - slew-rate: Integer, control slew rate of pins.
- 0: slow (half frequency)
- 1: fast
- drive-strength: Integer, control drive strength of pins in mA.
2: 2mA
4: 4mA
@@ -83,7 +80,7 @@ Valid values for pin and group names are:
drive groups:
- These support input-schmitt-enable, input-schmitt-disable, slew-rate,
+ These support input-schmitt-enable, input-schmitt-disable,
drive-strength, low-power-enable, and low-power-disable.
pdc
diff --git a/Documentation/devicetree/bindings/pinctrl/img,tz1090-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/img,tz1090-pinctrl.txt
index 39bfd9c..4b27c99 100644
--- a/Documentation/devicetree/bindings/pinctrl/img,tz1090-pinctrl.txt
+++ b/Documentation/devicetree/bindings/pinctrl/img,tz1090-pinctrl.txt
@@ -44,9 +44,6 @@ Optional subnode-properties:
- bias-pull-down
- input-schmitt-enable
- input-schmitt-disable
- - slew-rate: Integer, control slew rate of pins.
- 0: slow (half frequency)
- 1: fast
- drive-strength: Integer, control drive strength of pins in mA.
2: 2mA
4: 4mA
@@ -124,7 +121,6 @@ Valid values for pin and group names are:
function: afe, ts_out_0.
input-schmitt-enable: supported.
input-schmitt-disable: supported.
- slew-rate: supported.
drive-strength: supported.
pdm_d
pins: pdm_d.
@@ -153,12 +149,11 @@ Valid values for pin and group names are:
lcd_trace, phy_ringosc.
input-schmitt-enable: supported.
input-schmitt-disable: supported.
- slew-rate: supported.
drive-strength: supported.
drive groups:
- These all support input-schmitt-enable, input-schmitt-disable, slew-rate,
+ These all support input-schmitt-enable, input-schmitt-disable,
and drive-strength.
jtag
diff --git a/drivers/pinctrl/pinctrl-tz1090-pdc.c b/drivers/pinctrl/pinctrl-tz1090-pdc.c
index 12e4808..d4f12cc 100644
--- a/drivers/pinctrl/pinctrl-tz1090-pdc.c
+++ b/drivers/pinctrl/pinctrl-tz1090-pdc.c
@@ -809,11 +809,6 @@ static int tz1090_pdc_pinconf_group_reg(struct pinctrl_dev *pctldev,
*width = 1;
*map = tz1090_pdc_boolean_map;
break;
- case PIN_CONFIG_SLEW_RATE:
- *shift = REG_GPIO_CONTROL2_PDC_SR_S;
- *width = 1;
- *map = tz1090_pdc_boolean_map;
- break;
case PIN_CONFIG_DRIVE_STRENGTH:
*shift = REG_GPIO_CONTROL2_PDC_DR_S;
*width = 2;
diff --git a/drivers/pinctrl/pinctrl-tz1090.c b/drivers/pinctrl/pinctrl-tz1090.c
index 02ff3a2..4edae08 100644
--- a/drivers/pinctrl/pinctrl-tz1090.c
+++ b/drivers/pinctrl/pinctrl-tz1090.c
@@ -1834,11 +1834,6 @@ static int tz1090_pinconf_group_reg(struct pinctrl_dev *pctldev,
*width = 1;
*map = tz1090_boolean_map;
break;
- case PIN_CONFIG_SLEW_RATE:
- *reg = REG_PINCTRL_SR;
- *width = 1;
- *map = tz1090_boolean_map;
- break;
case PIN_CONFIG_DRIVE_STRENGTH:
*reg = REG_PINCTRL_DR;
*width = 2;
--
1.7.10.4
WARNING: multiple messages have this Message-ID (diff)
From: "Heiko Stübner" <heiko@sntech.de>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Stephen Warren <swarren@wwwdotorg.org>,
James Hogan <james.hogan@imgtec.com>,
linux-kernel@vger.kernel.org,
devicetree-discuss@lists.ozlabs.org,
Grant Likely <grant.likely@linaro.org>,
Rob Herring <rob.herring@calxeda.com>
Subject: [PATCH 3/4] pinctrl: remove slew-rate parameter from tz1090
Date: Tue, 25 Jun 2013 14:56:36 +0200 [thread overview]
Message-ID: <201306251456.36499.heiko@sntech.de> (raw)
In-Reply-To: <201306251455.01540.heiko@sntech.de>
As the binding for slew-rate is under discussion and seems to need
more tought it will get removed for now, so it doesn't get an offical
release.
Therefore remove it again from the only current user, tz1090.
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
---
.../devicetree/bindings/pinctrl/img,tz1090-pdc-pinctrl.txt | 5 +----
.../devicetree/bindings/pinctrl/img,tz1090-pinctrl.txt | 7 +------
drivers/pinctrl/pinctrl-tz1090-pdc.c | 5 -----
drivers/pinctrl/pinctrl-tz1090.c | 5 -----
4 files changed, 2 insertions(+), 20 deletions(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/img,tz1090-pdc-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/img,tz1090-pdc-
pinctrl.txt
index 9f7a85b..a186181 100644
--- a/Documentation/devicetree/bindings/pinctrl/img,tz1090-pdc-pinctrl.txt
+++ b/Documentation/devicetree/bindings/pinctrl/img,tz1090-pdc-pinctrl.txt
@@ -44,9 +44,6 @@ Optional subnode-properties:
- bias-pull-down
- input-schmitt-enable
- input-schmitt-disable
- - slew-rate: Integer, control slew rate of pins.
- 0: slow (half frequency)
- 1: fast
- drive-strength: Integer, control drive strength of pins in mA.
2: 2mA
4: 4mA
@@ -83,7 +80,7 @@ Valid values for pin and group names are:
drive groups:
- These support input-schmitt-enable, input-schmitt-disable, slew-rate,
+ These support input-schmitt-enable, input-schmitt-disable,
drive-strength, low-power-enable, and low-power-disable.
pdc
diff --git a/Documentation/devicetree/bindings/pinctrl/img,tz1090-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/img,tz1090-pinctrl.txt
index 39bfd9c..4b27c99 100644
--- a/Documentation/devicetree/bindings/pinctrl/img,tz1090-pinctrl.txt
+++ b/Documentation/devicetree/bindings/pinctrl/img,tz1090-pinctrl.txt
@@ -44,9 +44,6 @@ Optional subnode-properties:
- bias-pull-down
- input-schmitt-enable
- input-schmitt-disable
- - slew-rate: Integer, control slew rate of pins.
- 0: slow (half frequency)
- 1: fast
- drive-strength: Integer, control drive strength of pins in mA.
2: 2mA
4: 4mA
@@ -124,7 +121,6 @@ Valid values for pin and group names are:
function: afe, ts_out_0.
input-schmitt-enable: supported.
input-schmitt-disable: supported.
- slew-rate: supported.
drive-strength: supported.
pdm_d
pins: pdm_d.
@@ -153,12 +149,11 @@ Valid values for pin and group names are:
lcd_trace, phy_ringosc.
input-schmitt-enable: supported.
input-schmitt-disable: supported.
- slew-rate: supported.
drive-strength: supported.
drive groups:
- These all support input-schmitt-enable, input-schmitt-disable, slew-rate,
+ These all support input-schmitt-enable, input-schmitt-disable,
and drive-strength.
jtag
diff --git a/drivers/pinctrl/pinctrl-tz1090-pdc.c b/drivers/pinctrl/pinctrl-tz1090-pdc.c
index 12e4808..d4f12cc 100644
--- a/drivers/pinctrl/pinctrl-tz1090-pdc.c
+++ b/drivers/pinctrl/pinctrl-tz1090-pdc.c
@@ -809,11 +809,6 @@ static int tz1090_pdc_pinconf_group_reg(struct pinctrl_dev *pctldev,
*width = 1;
*map = tz1090_pdc_boolean_map;
break;
- case PIN_CONFIG_SLEW_RATE:
- *shift = REG_GPIO_CONTROL2_PDC_SR_S;
- *width = 1;
- *map = tz1090_pdc_boolean_map;
- break;
case PIN_CONFIG_DRIVE_STRENGTH:
*shift = REG_GPIO_CONTROL2_PDC_DR_S;
*width = 2;
diff --git a/drivers/pinctrl/pinctrl-tz1090.c b/drivers/pinctrl/pinctrl-tz1090.c
index 02ff3a2..4edae08 100644
--- a/drivers/pinctrl/pinctrl-tz1090.c
+++ b/drivers/pinctrl/pinctrl-tz1090.c
@@ -1834,11 +1834,6 @@ static int tz1090_pinconf_group_reg(struct pinctrl_dev *pctldev,
*width = 1;
*map = tz1090_boolean_map;
break;
- case PIN_CONFIG_SLEW_RATE:
- *reg = REG_PINCTRL_SR;
- *width = 1;
- *map = tz1090_boolean_map;
- break;
case PIN_CONFIG_DRIVE_STRENGTH:
*reg = REG_PINCTRL_DR;
*width = 2;
--
1.7.10.4
next prev parent reply other threads:[~2013-06-25 12:56 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-25 12:55 [PATCH 0/4] Fix more issues with generic pinconf bindings Heiko Stübner
2013-06-25 12:55 ` Heiko Stübner
2013-06-25 12:55 ` [PATCH 1/4] pinctrl: more clarifications for generic pull configs Heiko Stübner
2013-06-25 13:14 ` Linus Walleij
2013-06-25 12:56 ` [PATCH 2/4] pinctrl: set unit for debounce time pinconfig to usec Heiko Stübner
2013-06-25 13:15 ` Linus Walleij
[not found] ` <201306251455.01540.heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
2013-06-25 12:56 ` Heiko Stübner [this message]
2013-06-25 12:56 ` [PATCH 3/4] pinctrl: remove slew-rate parameter from tz1090 Heiko Stübner
2013-06-25 13:05 ` James Hogan
2013-06-25 13:05 ` James Hogan
2013-06-25 13:21 ` Heiko Stübner
2013-06-25 13:27 ` James Hogan
2013-06-25 13:27 ` James Hogan
2013-06-25 13:32 ` Linus Walleij
2013-06-25 13:50 ` James Hogan
2013-06-25 15:39 ` Linus Walleij
2013-06-25 21:40 ` Stephen Warren
2013-06-25 13:22 ` Linus Walleij
2013-06-25 14:57 ` James Hogan
2013-06-25 21:46 ` Stephen Warren
2013-06-27 8:32 ` Linus Walleij
2013-06-25 12:57 ` [PATCH 4/4] pinctrl: remove bindings for pinconf options needing more thought Heiko Stübner
2013-06-25 13:34 ` Linus Walleij
2013-06-25 13:16 ` [PATCH 0/4] Fix more issues with generic pinconf bindings James Hogan
2013-06-25 13:16 ` James Hogan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201306251456.36499.heiko@sntech.de \
--to=heiko-4mtyjxux2i+zqb+pc5nmwq@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=james.hogan-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org \
--cc=linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.