From: "Heiko Stübner" <heiko@sntech.de>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Stephen Warren <swarren@wwwdotorg.org>,
James Hogan <james.hogan@imgtec.com>,
linux-kernel@vger.kernel.org,
devicetree-discuss@lists.ozlabs.org,
Grant Likely <grant.likely@linaro.org>,
Rob Herring <rob.herring@calxeda.com>
Subject: [PATCH 4/4] pinctrl: remove bindings for pinconf options needing more thought
Date: Tue, 25 Jun 2013 14:57:10 +0200 [thread overview]
Message-ID: <201306251457.10980.heiko@sntech.de> (raw)
In-Reply-To: <201306251455.01540.heiko@sntech.de>
Some options currently take arguments in unspecified driver-specific units.
As pointed out by Stephen Warren, driver specific values should not be part
of generic devicetree bindings describing the hardware.
Therefore remove the critical bindings again, before they become part of
an official release.
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
---
.../devicetree/bindings/pinctrl/pinctrl-bindings.txt | 10 ----------
drivers/pinctrl/pinconf-generic.c | 3 ---
2 files changed, 13 deletions(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt b/Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt
index 788ab09..aeb3c99 100644
--- a/Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt
+++ b/Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt
@@ -154,10 +154,7 @@ drive-open-source - drive with open source
drive-strength - sink or source at most X mA
input-schmitt-enable - enable schmitt-trigger mode
input-schmitt-disable - disable schmitt-trigger mode
-input-schmitt - run in schmitt-trigger mode with hysteresis X
input-debounce - debounce mode with debound time X
-power-source - select power source X
-slew-rate - use slew-rate X
low-power-enable - enable low power mode
low-power-disable - disable low power mode
output-low - set the pin to output mode with low level
@@ -170,16 +167,9 @@ Arguments for parameters:
- drive-strength takes as argument the target strength in mA.
-- input-schmitt takes as argument the adjustable hysteresis in a
- driver-specific format
-
- input-debounce takes the debounce time in usec as argument
or 0 to disable debouncing
-- power-source argument is the custom value describing the source to select
-
-- slew-rate takes as argument the target rate in a driver-specific format
-
All parameters not listed here, do not take an argument.
More in-depth documentation on these parameters can be found in
diff --git a/drivers/pinctrl/pinconf-generic.c b/drivers/pinctrl/pinconf-generic.c
index 2b271d5..8594f03 100644
--- a/drivers/pinctrl/pinconf-generic.c
+++ b/drivers/pinctrl/pinconf-generic.c
@@ -161,10 +161,7 @@ static struct pinconf_generic_dt_params dt_params[] = {
{ "drive-strength", PIN_CONFIG_DRIVE_STRENGTH, 0 },
{ "input-schmitt-enable", PIN_CONFIG_INPUT_SCHMITT_ENABLE, 1 },
{ "input-schmitt-disable", PIN_CONFIG_INPUT_SCHMITT_ENABLE, 0 },
- { "input-schmitt", PIN_CONFIG_INPUT_SCHMITT, 0 },
{ "input-debounce", PIN_CONFIG_INPUT_DEBOUNCE, 0 },
- { "power-source", PIN_CONFIG_POWER_SOURCE, 0 },
- { "slew-rate", PIN_CONFIG_SLEW_RATE, 0 },
{ "low-power-enable", PIN_CONFIG_LOW_POWER_MODE, 1 },
{ "low-power-disable", PIN_CONFIG_LOW_POWER_MODE, 0 },
{ "output-low", PIN_CONFIG_OUTPUT, 0, },
--
1.7.10.4
next prev parent reply other threads:[~2013-06-25 12:57 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-25 12:55 [PATCH 0/4] Fix more issues with generic pinconf bindings Heiko Stübner
2013-06-25 12:55 ` Heiko Stübner
2013-06-25 12:55 ` [PATCH 1/4] pinctrl: more clarifications for generic pull configs Heiko Stübner
2013-06-25 13:14 ` Linus Walleij
2013-06-25 12:56 ` [PATCH 2/4] pinctrl: set unit for debounce time pinconfig to usec Heiko Stübner
2013-06-25 13:15 ` Linus Walleij
[not found] ` <201306251455.01540.heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
2013-06-25 12:56 ` [PATCH 3/4] pinctrl: remove slew-rate parameter from tz1090 Heiko Stübner
2013-06-25 12:56 ` Heiko Stübner
2013-06-25 13:05 ` James Hogan
2013-06-25 13:05 ` James Hogan
2013-06-25 13:21 ` Heiko Stübner
2013-06-25 13:27 ` James Hogan
2013-06-25 13:27 ` James Hogan
2013-06-25 13:32 ` Linus Walleij
2013-06-25 13:50 ` James Hogan
2013-06-25 15:39 ` Linus Walleij
2013-06-25 21:40 ` Stephen Warren
2013-06-25 13:22 ` Linus Walleij
2013-06-25 14:57 ` James Hogan
2013-06-25 21:46 ` Stephen Warren
2013-06-27 8:32 ` Linus Walleij
2013-06-25 12:57 ` Heiko Stübner [this message]
2013-06-25 13:34 ` [PATCH 4/4] pinctrl: remove bindings for pinconf options needing more thought Linus Walleij
2013-06-25 13:16 ` [PATCH 0/4] Fix more issues with generic pinconf bindings James Hogan
2013-06-25 13:16 ` James Hogan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201306251457.10980.heiko@sntech.de \
--to=heiko@sntech.de \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@linaro.org \
--cc=james.hogan@imgtec.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rob.herring@calxeda.com \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.