All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: Phil Oester <kernel@linuxace.com>, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] iptables: Fix connlabel.conf install location
Date: Tue, 25 Jun 2013 18:01:41 +0200	[thread overview]
Message-ID: <20130625160141.GA5816@localhost> (raw)
In-Reply-To: <20130612100605.GB21252@breakpoint.cc>

On Wed, Jun 12, 2013 at 12:06:05PM +0200, Florian Westphal wrote:
> Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> > > I think this is still useful for people cross-compiling and installing
> > > iptables in some custom location.
> > 
> > Hm, still, this may confuse people, as xt_connlabel always looks at:
> > 
> > #define CONNLABEL_CFG "/etc/xtables/connlabel.conf"
> 
> Right; this is easily fixable. However, this is also
> the default in libnetfilter_conntrack.  But lnf-ct wont be
> able to know what configure options iptables was built with.

We can define the default location in libnetfilter_conntrack.h, eg.

#define NFCT_CONNLABEL_CFG "/etc/xtables/connlabel.conf"

I think connlabel is not of much use without libnetfilter_conntrack,
since it provides the translation of the connlabel mapping. So we can
conditionally compile connlabel support if libnetfilter_conntrack is
installed. We can make it a soft dependency, ie. no need for
--enable-connlabel.

Regards.

  reply	other threads:[~2013-06-25 16:01 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-10  9:35 [PATCH] iptables: Fix connlabel.conf install location Phil Oester
2013-06-12  7:51 ` Florian Westphal
2013-06-12  8:50   ` Pablo Neira Ayuso
2013-06-12  9:08     ` Pablo Neira Ayuso
2013-06-12 10:06       ` Florian Westphal
2013-06-25 16:01         ` Pablo Neira Ayuso [this message]
2013-06-25 19:52           ` Florian Westphal
2013-07-03  0:13             ` Pablo Neira Ayuso
2013-06-12  8:04 ` Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130625160141.GA5816@localhost \
    --to=pablo@netfilter.org \
    --cc=fw@strlen.de \
    --cc=kernel@linuxace.com \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.