Re: [PATCH V2 lnf-ct 2/2] conntrack: snprintf: add connlabel format specifier

[Florian Westphal <fw@strlen.de>]

Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> On Sun, Jun 23, 2013 at 11:14:39PM +0200, Florian Westphal wrote:
> > By default, nfct_snprintf will not print connlabels, as they're
> > system specific and can easily generate lots of output.
> > 
> > This adds a fmt attribute to print connlabel names.
> > +static int
> > +__snprintf_clabels(char *buf, unsigned int len,
> > +		   const struct nf_conntrack *ct)
> > +{
> > +	const struct nfct_bitmask *b = nfct_get_attr(ct, ATTR_CONNLABELS);
> > +	struct nfct_labelmap *map;
> > +	int ret, size = 0, offset = 0;
> > +
> > +	if (!b)
> > +		return 0;
> > +
> > +	map = nfct_labelmap_new(NULL);
> > +	if (!map)
> > +		return 0;
> 
> This opens and parses the map file for each conntrack, it would be
> expensive.  I think it's better provide more control to the client
> regarding the load of the mapping, it's more flexible.
> 
> Consider adding:
> 
> int nfct_snprintf_connlabel(char *buf, unsigned int len,
>                             const struct nf_conntrack *ct,
>                             const struct nfct_labelmap *labelmap);

Thats what I'll do.

Thanks!