From: Dan Carpenter <dan.carpenter@oracle.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Jarod Wilson <jarod@wilsonet.com>,
Mauro Carvalho Chehab <mchehab@redhat.com>,
YAMANE Toshiaki <yamanetoshi@gmail.com>,
linux-media@vger.kernel.org
Subject: Re: [patch] [media] staging: lirc: clean error handling in probe()
Date: Wed, 26 Jun 2013 13:37:09 +0300 [thread overview]
Message-ID: <20130626103709.GL5714@mwanda> (raw)
In-Reply-To: <1372233640.24799.52.camel@smile>
On Wed, Jun 26, 2013 at 11:00:40AM +0300, Andy Shevchenko wrote:
> On Wed, 2013-06-26 at 10:53 +0300, Dan Carpenter wrote:
> > I have reorganized the error handling into a simpler and more canonical
> > format.
>
> Since you reorganize error handling, might be worth to convert it to
> devm_*?
>
> If you want I could do the patch.
Yeah. Using devm_kzalloc() would make it a lot simpler. That would
be great if you could re-write it that way. Thanks!
Please drop my patch in that case.
regards,
dan carpenter
prev parent reply other threads:[~2013-06-26 10:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-26 7:53 [patch] [media] staging: lirc: clean error handling in probe() Dan Carpenter
2013-06-26 8:00 ` Andy Shevchenko
2013-06-26 10:37 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130626103709.GL5714@mwanda \
--to=dan.carpenter@oracle.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=jarod@wilsonet.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@redhat.com \
--cc=yamanetoshi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.