From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] dfu:function: Fix number of allocated DFU function pointers
Date: Wed, 26 Jun 2013 14:07:49 +0200 [thread overview]
Message-ID: <201306261407.49601.marex@denx.de> (raw)
In-Reply-To: <51CAD210.9020306@denx.de>
Dear Heiko Schocher,
> Hello Lukasz,
>
> Am 26.06.2013 11:46, schrieb Lukasz Majewski:
> > This subtle change fix problem with too small amount of allocated
> > memory to store DFU function pointers.
> >
> > One needs to allocate extra space for sentinel NULL pointer in this array
> > of function pointers.
> >
> > With the previous code, the NULL value overwrites malloc internal data
> > and afterwards free(f_dfu->function) crashes.
> >
> > Signed-off-by: Lukasz Majewski <l.majewski@samsung.com>
> > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> > Cc: Marek Vasut <marex@denx.de>
> > ---
> >
> > drivers/usb/gadget/f_dfu.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Acked-by: Heiko Schocher <hs@denx.de>
Applied, thanks
Best regards,
Marek Vasut
prev parent reply other threads:[~2013-06-26 12:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-26 9:46 [U-Boot] [PATCH] dfu:function: Fix number of allocated DFU function pointers Lukasz Majewski
2013-06-26 11:35 ` Heiko Schocher
2013-06-26 12:07 ` Marek Vasut [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201306261407.49601.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.