From: Theodore Ts'o <tytso@mit.edu>
To: Dave Chinner <david@fromorbit.com>
Cc: linux-ext4@vger.kernel.org, Zheng Liu <gnehzuil.liu@gmail.com>
Subject: Re: [PATCH FOR DISCUSSION] add delalloc debugging
Date: Wed, 26 Jun 2013 10:41:42 -0400 [thread overview]
Message-ID: <20130626144142.GA32092@thunk.org> (raw)
In-Reply-To: <20130626131823.GA20140@dastard>
On Wed, Jun 26, 2013 at 11:18:23PM +1000, Dave Chinner wrote:
> Do not use VFS level locks and list walks in filesystem code,
> not even in debugging code. It's ok for you to do this in private
> patches and maintain such abuses yourself, but it's not acceptible
> for merging into the mainline tree...
Well, that's why I wasn't proposing that the code be enabled by
default, and why I described it as "a little gross".
> Besides, you haven't even used the correct lock - these bdi
> writeback lists are protected by the bdi writeback list lock, not
> the superblock inode list lock....
Thanks for pointing that out. I'll fix that.
Cheers,
- Ted
prev parent reply other threads:[~2013-06-26 14:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-20 16:42 [PATCH FOR DISCUSSION] add delalloc debugging Theodore Ts'o
2013-06-25 3:50 ` Zheng Liu
2013-06-26 12:31 ` Lukáš Czerner
2013-06-26 13:39 ` Theodore Ts'o
2013-06-26 13:18 ` Dave Chinner
2013-06-26 14:41 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130626144142.GA32092@thunk.org \
--to=tytso@mit.edu \
--cc=david@fromorbit.com \
--cc=gnehzuil.liu@gmail.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.