Re: [PATCH 2/2] glsdk: add the initial GLSDK branding policy

[Denys Dmytriyenko <denys@ti.com>]

On Wed, Jun 26, 2013 at 04:11:52PM +0000, Maupin, Chase wrote:
> >-----Original Message-----
> >From: meta-arago-bounces@arago-project.org [mailto:meta-arago-
> >bounces@arago-project.org] On Behalf Of Cooper Jr., Franklin
> >Sent: Wednesday, June 26, 2013 10:31 AM
> >To: Heroor, Siddharth; meta-arago@arago-project.org
> >Subject: Re: [meta-arago] [PATCH 2/2] glsdk: add the initial GLSDK
> >branding policy
> >
> >> -----Original Message-----
> >> From: meta-arago-bounces@arago-project.org [mailto:meta-arago-
> >> bounces@arago-project.org] On Behalf Of Heroor, Siddharth
> >> Sent: Wednesday, June 26, 2013 6:03 AM
> >> To: meta-arago@arago-project.org
> >> Subject: [meta-arago] [PATCH 2/2] glsdk: add the initial GLSDK
> >branding policy
> >>
> >> * Choose ti-linux-glsdk as the preferred provider
> >>
> >> Signed-off-by: Siddharth Heroor <heroor@ti.com>
> >> cc: Mrinmayee Hingolikar <mrinmayee@ti.com>
> >> ---
> >>  .../conf/distro/include/branding-glsdk.inc         |    4 ++++
> >>  1 files changed, 4 insertions(+), 0 deletions(-)  create mode
> >100644 meta-
> >> arago-distro/conf/distro/include/branding-glsdk.inc
> >>
> >> diff --git a/meta-arago-distro/conf/distro/include/branding-
> >glsdk.inc b/meta-
> >> arago-distro/conf/distro/include/branding-glsdk.inc
> >> new file mode 100644
> >> index 0000000..d1c30f3
> >> --- /dev/null
> >> +++ b/meta-arago-distro/conf/distro/include/branding-glsdk.inc
> >> @@ -0,0 +1,4 @@
> >> +# GLSDK branding configuration
> >> +
> >> +# Use the SDK supported kernel and kernel version
> >> +PREFERRED_PROVIDER_virtual/kernel = "linux-ti-glsdk"
> >
> >I am not familiar with the GLSDK but I am not sure why you need
> >your own branding include file. This patch shows you want to
> >change the kernel but this really should be done in meta-ti within
> >each of the machine configuration files. I will let Denys comment
> >but if you really can't put this within meta-ti then you should at
> >least make this statement machine or at least SOC specific.
> >
> >Branding-amsdk.inc only exist due to the mainline effort for
> >am335x. Currently the Sitara team supports am335x on the 3.2
> >kernel while the kernel team is working on getting am335x in
> >mainline. So satisfy both kernels the branding include file was
> >created.
> 
> Another example would be if you want to use QT5 instead of QT4 to set 
> preferred versions and providers for your SDK.

So, how this is different? Until we see the actual kernel recipe, I'm inclined 
to believe this patch is valid and correct. Especially if it's altering one of 
our existing machines and kernel recipes specifically for GLSDK. That is what 
branding was created for in the first place.


> >Unless your team's work falls in a similar situation there isn't a
> >need to create this file. I personally don't like the branding
> >include file and plan on getting rid of the amsdk file once we
> >release a mainline am335x SDK.
> >
> >Also I don't see a recipe for linux-ti-glsdk within meta-ti.
> >
> >> --
> >> 1.7.0.4
> >>
> >> _______________________________________________
> >> meta-arago mailing list
> >> meta-arago@arago-project.org
> >> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
> >_______________________________________________
> >meta-arago mailing list
> >meta-arago@arago-project.org
> >http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago