From: Ralf Baechle <ralf@linux-mips.org>
To: "Steven J. Hill" <Steven.Hill@imgtec.com>
Cc: Tony Wu <tung7970@gmail.com>,
linux-mips@linux-mips.org,
Chris Dearman <chris.dearman@imgtec.com>
Subject: Re: [PATCH] MIPS: Fix gic_set_affinity infinite loop
Date: Wed, 26 Jun 2013 21:05:47 +0200 [thread overview]
Message-ID: <20130626190547.GK7171@linux-mips.org> (raw)
In-Reply-To: <51C486DF.4020303@imgtec.com>
On Fri, Jun 21, 2013 at 12:01:19PM -0500, Steven J. Hill wrote:
> On 06/21/2013 06:13 AM, Tony Wu wrote:
> >There is an infinite loop in gic_set_affinity. When irq_set_affinity
> >gets called on gic controller, it blocks forever.
> >
> Tony,
>
> What hardware platform is this on and how do you trigger the call to
> 'gic_set_affinity' such that you get stuck? Thanks.
I assume on a SMP GIC configuration he must have tried something like
echo 1 > /proc/irq/2/smp_affinity
Where 1 is a CPU bit mask and 2 the number of a GIC interrupt of which
to change the affinity.
This is a hillarious bug, this obviously has never been working.
I'm not sure if anything else would need fixing or if the loop had any
sane purpose but as of now I can't see one so I'm queueing the patch
for linux-next.
Ralf
next prev parent reply other threads:[~2013-06-26 19:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-21 11:13 [PATCH] MIPS: Fix gic_set_affinity infinite loop Tony Wu
2013-06-21 17:01 ` Steven J. Hill
2013-06-21 17:01 ` Steven J. Hill
2013-06-26 19:05 ` Ralf Baechle [this message]
2013-06-26 22:23 ` Steven J. Hill
2013-06-26 22:23 ` Steven J. Hill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130626190547.GK7171@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=Steven.Hill@imgtec.com \
--cc=chris.dearman@imgtec.com \
--cc=linux-mips@linux-mips.org \
--cc=tung7970@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.