From: "Michael S. Tsirkin" <mst@redhat.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: netdev <netdev@vger.kernel.org>
Subject: Re: [RFC] about "net: orphan frags on receive" insanity
Date: Wed, 26 Jun 2013 22:22:02 +0300 [thread overview]
Message-ID: <20130626192202.GB10713@redhat.com> (raw)
In-Reply-To: <1372273764.3301.200.camel@edumazet-glaptop>
On Wed, Jun 26, 2013 at 12:09:24PM -0700, Eric Dumazet wrote:
> On Wed, 2013-06-26 at 21:56 +0300, Michael S. Tsirkin wrote:
>
> > Well we don't want to duplicate the whole RX path
> > to special-case that, right?
>
>
> Whats wrong using a helper ?
>
> I_Should_cleanup_things(skb)
> {
> ... // cleanup for these special users trying to reenter stack
>
> netif_rx(skb);
> }
>
The point is we don't know the final destination of the packet
until it's going through the stack.
We don't want to trigger a copy for all data we get from tun:
we only want to do this if the data has a chance to get
queued somewhere indefinitely.
--
MST
next prev parent reply other threads:[~2013-06-26 19:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-26 8:23 [RFC] about "net: orphan frags on receive" insanity Eric Dumazet
2013-06-26 9:56 ` Michael S. Tsirkin
2013-06-26 10:12 ` Eric Dumazet
2013-06-26 18:56 ` Michael S. Tsirkin
2013-06-26 19:09 ` Eric Dumazet
2013-06-26 19:22 ` Michael S. Tsirkin [this message]
2013-06-26 19:44 ` Eric Dumazet
2013-06-27 7:09 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130626192202.GB10713@redhat.com \
--to=mst@redhat.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.