From: Thierry Reding <thierry.reding@gmail.com>
To: Axel Lin <axel.lin@ingics.com>
Cc: Steffen Trumtrar <s.trumtrar@pengutronix.de>, linux-pwm@vger.kernel.org
Subject: Re: [PATCH] pwm: pca9685: Fix wrong argument to set MODE1_SLEEP bit
Date: Wed, 26 Jun 2013 23:33:12 +0200 [thread overview]
Message-ID: <20130626213312.GA29479@manwe> (raw)
In-Reply-To: <1371662847.5355.2.camel@phoenix>
[-- Attachment #1: Type: text/plain, Size: 536 bytes --]
On Thu, Jun 20, 2013 at 01:27:27AM +0800, Axel Lin wrote:
> Current code actually does not set MODE1_SLEEP bit because the new value for
> bitmask (0x1) is wrong. To set MODE1_SLEEP bit, we should pass MODE1_SLEEP
> as the new value for bitmask.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> Hi Steffen,
> I don't have this hardware, can you test if this patch works?
> Thanks,
> Axel
>
> drivers/pwm/pwm-pca9685.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
Applied, thanks.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2013-06-26 21:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-19 17:27 [PATCH] pwm: pca9685: Fix wrong argument to set MODE1_SLEEP bit Axel Lin
2013-06-26 9:51 ` Thierry Reding
2013-06-26 12:09 ` Steffen Trumtrar
2013-06-26 21:33 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130626213312.GA29479@manwe \
--to=thierry.reding@gmail.com \
--cc=axel.lin@ingics.com \
--cc=linux-pwm@vger.kernel.org \
--cc=s.trumtrar@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.