All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V2] ARM: mxs: Consolidate configuration options
Date: Wed, 26 Jun 2013 21:56:43 +0200	[thread overview]
Message-ID: <201306262156.43650.marex@denx.de> (raw)
In-Reply-To: <51CAFD67.7050409@denx.de>

Hi Stefano,

> Hi Marek,
> 
> On 16/06/2013 15:39, Marek Vasut wrote:
> > Pull all the duplicate configuration options into configs/mxs.h
> > from the board configuration files. This reduces the files greatly
> > and makes them somewhat more readable. Besides, we do no longer
> > have such a horrible duplication of code.
> > 
> > Note that the mx23evk grew in size slightly. This is due to the
> > CONFIG_SYS_CBSIZE now being set to 1024 as it is on the rest of
> > MXS systems.
> > 
> > This patch also fixes the OCRAM size for i.MX23. The i.MX23 has
> > only 32kB of OCRAM, while i.MX28 has 128kB of OCRAM.
> > 
> > I verified the configuration didn't change for each of the boards,
> > but I didn't boot-test it on the boards I do not have. I configured
> > U-Boot for each board using the "make ... <board>_config" command
> > and then ran "cpp -I include -dM include/config.h" , which dumped
> > all the configuration options. I did this both before and after this
> > patch and finally compared the results for each MXS board. Actually,
> > the results do differ slightly, since the configs/mxs.h file now
> > properly includes the correct iomux-mx23.h or iomux-mx28.h , so
> > while comparing, I had to ignore these new defines. These have no
> > impact on U-Boot configuration though.
> > 
> > Signed-off-by: Marek Vasut <marex@denx.de>
> > Cc: Fabio Estevam <fabio.estevam@freescale.com>
> > Cc: Lauri Hintsala <lauri.hintsala@bluegiga.com>
> > Cc: Otavio Salvador <otavio@ossystems.com.br>
> > Cc: Stefano Babic <sbabic@denx.de>
> > ---
> 
> This is a nice cleanup, but as we probably cannot test all boards before
> release, I apply it to u-boot-imx, next branch.

Come on guys, test this! I know you want to have it in current release ;-)

Best regards,
Marek Vasut

      reply	other threads:[~2013-06-26 19:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-15 17:12 [U-Boot] [PATCH] ARM: mxs: Consolidate configuration options Marek Vasut
2013-06-15 20:17 ` Wolfgang Denk
2013-06-15 20:27   ` Marek Vasut
2013-06-15 21:42     ` Marek Vasut
2013-06-16 13:39 ` [U-Boot] [PATCH V2] " Marek Vasut
2013-06-26 14:40   ` Stefano Babic
2013-06-26 19:56     ` Marek Vasut [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201306262156.43650.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.