From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4 0/8] Provide a mechanism to avoid using #ifdef everywhere
Date: Thu, 27 Jun 2013 09:04:35 +0200 [thread overview]
Message-ID: <20130627090435.464a5355@lilith> (raw)
In-Reply-To: <CAPnjgZ3DmYMtotdCfwq7S6Rvah65uVyxDdtnWMa=+LgJ8WPsPA@mail.gmail.com>
Hi Simon,
On Mon, 24 Jun 2013 17:52:03 -0700, Simon Glass <sjg@chromium.org>
wrote:
> Hi Albert,
>
> On Sun, Jun 23, 2013 at 12:29 AM, Albert ARIBAUD
> <albert.u.boot@aribaud.net>wrote:
>
> > Hi Simon,
> >
> > On Mon, 17 Jun 2013 07:44:52 -0700, Simon Glass <sjg@chromium.org>
> > wrote:
> >
> > > Note that a config_drop.h file is added - this defines all the CONFIGs
> > > which are not used in any board config file. Without this, autoconf
> > cannot
> > > define the macros for this CONFIGs.
> > >
> > > Compile time for main.c does not seem to be any different in my tests.
> > The
> > > time to perform the 'dep' step (which now creates autoconf.h) increases,
> > > from about 2.8s to about 4.6s. This additional time is used to grep, sed
> > > and sort the contents of all the header file in U-Boot. The time for an
> > > incremental build is not affected.
> > >
> > > It would be much more efficient to maintain a list of all available
> > CONFIG
> > > defines, but no such list exists at present.
> >
> > Stop me if I am wrong, but do you not have this list already, since at
> > one point you grep, sed and sort the whole list of config options, then
> > at another point generate the list of unused ones?
> >
>
> Well yes I create the list. But I don't 'have' it in the sense that it is a
> pre-existing file in the tree. My point was that if the file existed I
> would not need to create it in the build system. I asked about this at one
> point, and the comment was made that putting it in the source tree
> 'staticly' is risky, since someone might add a new option and it would not
> work.
>
> Perhaps when Kconfig is in there things will be different.
Understod.
> > Granted, that's the list of config options defined, not necessarily the
> > list of options used, but a second variation of the grep/sed/sort might
> > give you a hint on that.
> >
> > Plus, I would love having scripts in tools/ that look for either
> > defined or used config options.
> >
>
> With this series you kind-of get this feature - you can look at the files
> it creates along the way.
What I meant is, this patch creates those lists with scripts. I'd like
these scripts to be available to the developer in tools/ so that anyone
can regenerate the lists (and do this only) at any time.
> Regards,
> Simon
Amicalement,
--
Albert.
next prev parent reply other threads:[~2013-06-27 7:04 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-17 14:44 [U-Boot] [PATCH v4 0/8] Provide a mechanism to avoid using #ifdef everywhere Simon Glass
2013-06-17 14:44 ` [U-Boot] [PATCH v4 1/8] Implement autoconf header file Simon Glass
2013-06-17 14:44 ` [U-Boot] [PATCH v4 2/8] main: Use autoconf for boot retry feature Simon Glass
2013-06-17 14:44 ` [U-Boot] [PATCH v4 3/8] main: Remove CONFIG #ifdefs from the abortboot() code Simon Glass
2013-06-17 14:44 ` [U-Boot] [PATCH v4 4/8] main: Use autoconf to remove #ifdefs around process_boot_delay() Simon Glass
2013-10-28 14:19 ` Michal Simek
2013-06-17 14:44 ` [U-Boot] [PATCH v4 5/8] main: Use autoconf for boot_delay code Simon Glass
2013-06-17 14:44 ` [U-Boot] [PATCH v4 6/8] main: Use autoconf for parser selection Simon Glass
2013-06-17 14:44 ` [U-Boot] [PATCH v4 7/8] main: Use autoconf in command line reading Simon Glass
2013-06-17 14:45 ` [U-Boot] [PATCH v4 8/8] main: Use autoconf in main_loop() Simon Glass
2013-06-23 7:29 ` [U-Boot] [PATCH v4 0/8] Provide a mechanism to avoid using #ifdef everywhere Albert ARIBAUD
2013-06-25 0:52 ` Simon Glass
2013-06-27 7:04 ` Albert ARIBAUD [this message]
2013-06-27 7:15 ` Simon Glass
-- strict thread matches above, loose matches on Subject: below --
2013-10-26 15:14 Simon Glass
2013-10-28 14:44 ` Wolfgang Denk
2013-10-28 15:32 ` Tom Rini
2013-10-28 20:31 ` Simon Glass
2013-11-06 7:24 ` Wolfgang Denk
2013-11-06 8:30 ` Stefan Roese
2013-11-07 9:20 ` Albert ARIBAUD
2013-11-10 4:24 ` Simon Glass
2013-11-10 12:58 ` Wolfgang Denk
2014-01-14 10:11 ` Detlev Zundel
2014-01-15 18:11 ` Simon Glass
2014-01-17 15:13 ` Detlev Zundel
2014-01-26 20:58 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130627090435.464a5355@lilith \
--to=albert.u.boot@aribaud.net \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.