From: chrubis@suse.cz
To: Wanlong Gao <gaowanlong@cn.fujitsu.com>
Cc: Garrett Cooper <yanegomi@gmail.com>,
LTP <ltp-list@lists.sourceforge.net>,
Mike Frysinger <vapier@gentoo.org>
Subject: Re: [LTP] [PATCH] aio02: remove test for aio_fsync() and aio_fdsync()
Date: Thu, 27 Jun 2013 14:43:54 +0200 [thread overview]
Message-ID: <20130627124354.GD5384@rei> (raw)
In-Reply-To: <1372322290-21498-1-git-send-email-gaowanlong@cn.fujitsu.com>
Hi!
> Linux filesystems doesn't support aio_fsync() and aio_fdsync()
> operations, so just remove test for these two.
>
> Signed-off-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>
The patch is OK but the commit description is a bit misleading.
Do not mix the POSIX aio_* which is implemented in userspace in libc and
Linux kernel io_* interface that implements AIO in linux kernel. I would
use the IO_* constants in the commit message instead of the aio_*
functions which seems to misleadingly suggest the libc implementation.
--
Cyril Hrubis
chrubis@suse.cz
------------------------------------------------------------------------------
This SF.net email is sponsored by Windows:
Build for Windows Store.
http://p.sf.net/sfu/windows-dev2dev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
prev parent reply other threads:[~2013-06-27 12:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1372322290-21498-1-git-send-email-gaowanlong@cn.fujitsu.com>
2013-06-27 9:30 ` [LTP] [PATCH] aio02: remove test for aio_fsync() and aio_fdsync() Jan Stancek
2013-06-27 12:43 ` chrubis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130627124354.GD5384@rei \
--to=chrubis@suse.cz \
--cc=gaowanlong@cn.fujitsu.com \
--cc=ltp-list@lists.sourceforge.net \
--cc=vapier@gentoo.org \
--cc=yanegomi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.