From: chrubis@suse.cz
To: Carlos Hernandez <ceh@ti.com>
Cc: ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH] runtest/ipc: Add some IPC syscalls test-cases
Date: Thu, 27 Jun 2013 15:28:57 +0200 [thread overview]
Message-ID: <20130627132857.GB21560@rei> (raw)
In-Reply-To: <51CC3C3B.2020803@ti.com>
Hi!
> >>> Signed-off-by: Sedat Dilek<sedat.dilek@gmail.com>
> >>> ---
> >>> runtest/ipc | 60 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> >>> 1 file changed, 60 insertions(+)
> >> NAK. Duplication is generally a bad idea.
> >> This have the side effect of running the same tests twice for people
> >> that run ipc and syscalls test scenarios.
> > Hmm, this is a valid point.
> >
> > Thinking of the ideal way, it may be more data driven framework with a
> > list of all tests anotated with some group labels. I noted this for the
> > planned testdriver rewrite.
> >
>
> We can easily support this with existing infrastructure if we add some
> structure to the test case tags.
> For instance on runtest/syscalls, one could use:
> msgctl01_ipc
> msgctl02_ipc
> ...
>
> Then when calling runltp, one can use -s option to filter tests cases,
> e.g. ./runltp -f syscalls -s '*_ipc'
>
> At Texas Instruments we use following convention for TAG names
> <AREA>_<SCOPE>_<TYPE>_<ID>
>
>
That is no go, at least here we have database of testruns for different
distributions and renaming the testcases tags will break the regression
detection. So I would preffer solution that adds a metadata without
renaming the current test tags. The problem is that ltp-pan and runltp
are so horribly outdated and unmaintaned that adding functionality to
these is out of question.
--
Cyril Hrubis
chrubis@suse.cz
------------------------------------------------------------------------------
This SF.net email is sponsored by Windows:
Build for Windows Store.
http://p.sf.net/sfu/windows-dev2dev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next prev parent reply other threads:[~2013-06-27 13:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1372336933-2770-1-git-send-email-sedat.dilek@gmail.com>
[not found] ` <51CC37E2.20304@ti.com>
2013-06-27 13:09 ` [LTP] [PATCH] runtest/ipc: Add some IPC syscalls test-cases chrubis
[not found] ` <51CC3C3B.2020803@ti.com>
2013-06-27 13:28 ` chrubis [this message]
[not found] ` <CA+icZUW2hCKtEV-yvYSDrnuVW=MmB0ywTvKTPnStqWgmiAhKmg@mail.gmail.com>
2013-06-27 13:24 ` chrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130627132857.GB21560@rei \
--to=chrubis@suse.cz \
--cc=ceh@ti.com \
--cc=ltp-list@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.